Skip to content

Add fsGroupPolicy to driver #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

dabradley
Copy link
Collaborator

In order to be able to use non-root accounts, it is important for the driver to allow k8s to change group ids in the cluster. Adding this value enables this ability so that in all circumstances, a pod can run with the expected filesystem group ACLs set.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

In order to be able to use non-root accounts, it is important for
the driver to allow k8s to change group ids in the cluster. Adding
this value enables this ability so that in all circumstances,
a pod can run with the expected filesystem group ACLs set.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@dabradley dabradley removed the request for review from andyzhangx January 6, 2025 20:18
@coveralls
Copy link

Coverage Status

coverage: 81.844%. remained the same
when pulling c5636ee on personal/dabradley/add-fs-group-policy
into e1b5cc3 on development.

Copy link
Collaborator

@t-mialve t-mialve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dabradley, t-mialve

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aac2d50 into development Jan 6, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot deleted the personal/dabradley/add-fs-group-policy branch January 6, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants