Skip to content

Add dalec integration testing #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

t-mialve
Copy link
Collaborator

@t-mialve t-mialve commented Apr 8, 2025

What type of PR is this?

Add an integration test specifically for dalec

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 8, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 8, 2025
@coveralls
Copy link

coveralls commented Apr 8, 2025

Pull Request Test Coverage Report for Build 14384574495

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.793%

Totals Coverage Status
Change from base Build 14336025724: 0.0%
Covered Lines: 1168
Relevant Lines: 1428

💛 - Coveralls

@t-mialve t-mialve force-pushed the t-mialve/integration-testing branch from 836a1a3 to b52f8b2 Compare April 8, 2025 20:26
@t-mialve t-mialve force-pushed the t-mialve/integration-testing branch 9 times, most recently from 59bc280 to a4c8ccc Compare April 9, 2025 19:21
@t-mialve t-mialve force-pushed the t-mialve/integration-testing branch from a4c8ccc to 51592a7 Compare April 9, 2025 20:15
@t-mialve t-mialve marked this pull request as ready for review April 10, 2025 13:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dabradley April 10, 2025 13:54
@t-mialve t-mialve force-pushed the t-mialve/integration-testing branch from 805afb9 to 0f7a3b1 Compare April 10, 2025 15:37
Copy link
Collaborator

@dabradley dabradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dabradley, t-mialve

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit d5a05ba into kubernetes-sigs:development Apr 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants