Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for metallb shared addresses #580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add support for metallb shared addresses #580

wants to merge 1 commit into from
+192 −39

Conversation

TimJones
Copy link
Contributor

@TimJones TimJones commented Nov 7, 2024

Add support for shared IP addresses with MetalLB in the CRD configuration.

Fixes #579

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 7, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: TimJones / name: Tim Jones (14af1b8)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TimJones
Once this PR has been reviewed and has the lgtm label, please assign andrewsykim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@TimJones TimJones force-pushed the metallb-shared-ip branch 6 times, most recently from 4d5bbff to 9bc203b Compare November 8, 2024 12:54
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 8, 2024
@TimJones TimJones force-pushed the metallb-shared-ip branch 2 times, most recently from 4a88d59 to a6cd4c5 Compare November 8, 2024 13:00
@TimJones
feat: add support for metallb shared addresses
14af1b8 
Add support for shared IP addresses with MetalLB in the CRD
configuration.

Signed-off-by: Tim Jones <tim.jones@siderolabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch Awaiting requested review from deitch

@displague displague Awaiting requested review from displague

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support shared IP assignment for MetalLB CRDs
2 participants
@TimJones @k8s-ci-robot