-
Notifications
You must be signed in to change notification settings - Fork 108
🌱 Add insecureDiagnostics and diagnosticsAddress to chart #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🌱 Add insecureDiagnostics and diagnosticsAddress to chart #911
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @fariaass. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
hack/charts/cluster-api-operator/templates/infra-conditions.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Furkat Gofurov <furkat.gofurov@suse.com>
/retest |
@furkatgofurov7 I removed the |
@fariaass: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This PR adds the fields
insecureDiagnostics
anddiagnosticsAddress
to the chart. It also refactors the manager field to be configurable per component.These fields are necessary to configure the metrics exposure of the components.