Skip to content

⚠️ Support storing Ignition user data in S3 bucket for AWSMachinePool #1179

⚠️ Support storing Ignition user data in S3 bucket for AWSMachinePool

⚠️ Support storing Ignition user data in S3 bucket for AWSMachinePool #1179

Triggered via pull request October 10, 2024 15:17
Status Failure
Total duration 5m 6s
Artifacts

pr-golangci-lint.yaml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

9 errors
lint: exp/controllers/awsmachinepool_controller.go#L408
declaration has 3 blank identifiers (dogsled)
lint: pkg/cloud/services/s3/s3.go#L542
appendCombine: can combine chain of 2 appends into one (gocritic)
lint: pkg/cloud/services/ec2/launchtemplate_test.go#L88
appendCombine: can combine chain of 2 appends into one (gocritic)
lint: pkg/cloud/services/s3/s3.go#L222
exported: exported method Service.CreateForMachinePool should have comment or be unexported (revive)
lint: pkg/cloud/services/s3/s3.go#L339
exported: exported method Service.DeleteForMachinePool should have comment or be unexported (revive)
lint: exp/controllers/awsmanagedmachinepool_controller.go#L221
var-declaration: should drop = nil from declaration of var objectStoreSvc; it is the zero value (revive)
lint: exp/api/v1beta2/awsmachinepool_webhook.go#L30
ST1019: package "sigs.k8s.io/cluster-api-provider-aws/v2/api/v1beta2" is being imported more than once (stylecheck)
lint: exp/api/v1beta2/awsmachinepool_webhook.go#L31
ST1019(related information): other import of "sigs.k8s.io/cluster-api-provider-aws/v2/api/v1beta2" (stylecheck)
lint
issues found