🐛 Updating verify kubectl version script

[prometherion]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4719

Special notes for your reviewer:

This PR is a pre-requisite to fix the blocked CI of #4710.

Essentially, the --short flag has been deprecated and removed from v1.29.
To keep backward compatibility, although the infra image has already kubectl baked in, the --output=yaml flag is used as a replacement.

Checklist:

• squashed commits
• includes documentation
• includes emojis
• adds unit tests
• adds or updates e2e tests

Release note:

NONE

[k8s-ci-robot]

Hi @prometherion. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[richardcase]

/ok-to-test

[richardcase]

Thanks for this @prometherion. I had just done the same, but you beat me to it :)

What do you think to bringing the script more in line with the upstream CAPI version? Which will also require a small change to utils.sh (i.e. add the verify_gopath_bin function).

[prometherion]

Thanks, @richardcase, I just aligned the files as you suggested.

[richardcase]

I think after rebasing because of #4710 this will go green

[prometherion]

Correct, thanks @richardcase!

[Ankitasw]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Ankitasw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment