-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ controlplane/rosa: allow configuring private link #4758
Changes from all commits
7bb8ea0
2c62cf9
46eda01
e278d2e
3fbec96
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,6 +74,22 @@ type RosaControlPlaneSpec struct { //nolint: maligned | |
// - ocmApiUrl: Optional, defaults to 'https://api.openshift.com' | ||
// +optional | ||
CredentialsSecretRef *corev1.LocalObjectReference `json:"credentialsSecretRef,omitempty"` | ||
|
||
// AWS configures aspects of the ROSA HCP workload cluster that are specific to AWS. | ||
AWS AWSConfiguration `json:"aws"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this field required? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
|
||
type AWSConfiguration struct { | ||
// PrivateLink configures whether Private Link is enabled for the cluster | ||
PrivateLink bool `json:"privateLink"` | ||
|
||
// PrivateLinkConfiguration configures the Private Link for the cluster | ||
PrivateLinkConfiguration *PrivateLinkConfiguration `json:"privateLinkConfiguration,omitempty"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How does someone configure the principals with the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think its possible to configure this, maybe only SREs have access. |
||
} | ||
|
||
type PrivateLinkConfiguration struct { | ||
// Principals are the ARNs for principals that are allowed for the Private Link. | ||
Principals []string `json:"principals,omitempty"` | ||
} | ||
|
||
// AWSRolesRef contains references to various AWS IAM roles required for operators to make calls against the AWS API. | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously
Makefile
couldn't handle$GOPATH
with trailing/
...