📖 Improve ROSA quickstart with MachinePool and troubleshooting guide #4775
Conversation
k8s-ci-robot
added
kind/bug
|
Hi @serngawy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
release-note-none
| ```shell | ||
| $ kubectl get deploy capi-controller-manager -n capi-system -o yaml | ||
| ``` | ||
| check the feature gate container args it should has the MachinePool=true as below. |
There was a problem hiding this comment.
| check the feature gate container args it should has the MachinePool=true as below. | |
| the feature gate container arg should have `MachinePool=true` as shown below. |
| ```shell | ||
| $ kubectl get deploy capa-controller-manager -n capa-system -o yaml | ||
| ``` | ||
| check the feature gate container args it should has the ROSA=true as below. |
There was a problem hiding this comment.
| check the feature gate container args it should has the ROSA=true as below. | |
| the feature gate arg should have `ROSA=true` as shown below. |
|
Just a couple suggestions for wording, otherwise this looks good. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
Could you update the commit message and title to reflect what the change does, rather than the issue number? You can see what emoji to use for the PR title here |
| clusterctl init --infrastructure aws | ||
| ``` | ||
|
|
||
| ## TroubleShoot |
There was a problem hiding this comment.
| ## TroubleShoot | |
| ## Troubleshooting |
| spec: | ||
| containers: | ||
| - args: | ||
| - --feature-gates=ROSA=true,... |
There was a problem hiding this comment.
change to 2 spacing for better readability?
| ``` | ||
|
|
||
| ## TroubleShoot | ||
| To check the feature-gates for the capi contoller Run the following command. |
There was a problem hiding this comment.
| To check the feature-gates for the capi contoller Run the following command. | |
| To check the feature-gates for the Cluster API controller run the following command: |
| - --feature-gates=MachinePool=true,ClusterResourceSet=true,ClusterTopology=true,RuntimeSDK=false,MachineSetPreflightChecks=false | ||
| ``` | ||
|
|
||
| To check the feature-gates for the capa contoller Run the following command. |
There was a problem hiding this comment.
| To check the feature-gates for the capa contoller Run the following command. | |
| To check the feature gates for the Cluster API AWS controller run the following command: |
|
/retitle 📖 Improve ROSA quickstart with MachinePool and troubleshooting guide |
k8s-ci-robot
changed the title
Signed-off-by: melserngawy <melserng@redhat.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
What this PR does / why we need it:
Enable the machinePool feature in order to be able to use ROSA machine pool feature
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
#4774
Special notes for your reviewer:
Checklist:
Release note: