Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use Kube v1.29.1 for EKS e2e tests #4779

Merged
merged 1 commit into from
Feb 7, 2024
Merged

🐛 Use Kube v1.29.1 for EKS e2e tests #4779

merged 1 commit into from
Feb 7, 2024

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Feb 6, 2024

What type of PR is this?

/kind bug

-->

What this PR does / why we need it:

Kubernetes v1.24 is entering into an extended support window that adds additional cost for EKS clusters. This PR moves to v1.29.1, the latest version of Kubernetes, in order to avoid that infrastructure cost.

Standard EKS support for this version ends March 23, 2026.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4777

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes emojis
  • adds or updates e2e tests

Release note:

NONE

@nrb
Update EKS test version to v1.29.1
56cb092 
Update to be within the 'standard' support window.
v1.29 leaves the standard support window March 23, 2026.

Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2024
@nrb
Copy link
Contributor Author

nrb commented Feb 6, 2024

/test ?

@k8s-ci-robot
Copy link
Contributor

@nrb: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nrb
Copy link
Contributor Author

nrb commented Feb 6, 2024

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc
/test pull-cluster-api-provider-aws-e2e-eks-testing

@nrb
Copy link
Contributor Author

nrb commented Feb 6, 2024

/test pull-cluster-api-provider-aws-e2e-eks-testing

@Ankitasw
Copy link
Member

Ankitasw commented Feb 7, 2024

Thanks for this PR @nrb , can you also make changes for CAPA regular E2E tests as well, so that changes in EKS tests and CAPA E2E tests are same?

@richardcase
Copy link
Member

can you also make changes for CAPA regular E2E tests as well, so that changes in EKS tests and CAPA E2E tests are same?

Lets do that it a different PR, so that we can get this in.

@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@richardcase
Copy link
Member

Thanks for picking this up @nrb

@k8s-ci-robot k8s-ci-robot merged commit 9dfa0a3 into kubernetes-sigs:main Feb 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@richardcase richardcase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[E2E] Update k8s version for EKS so we aren't using an extended support version
4 participants
@nrb @k8s-ci-robot @Ankitasw @richardcase