Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ rosa: add missing fields to spec #4832

Closed
wants to merge 4 commits into from
Closed

✨ rosa: add missing fields to spec #4832

wants to merge 4 commits into from

Conversation

stevekuznetsov
Copy link
Contributor

This supersedes #4802 and #4758

xiangjingli and others added 2 commits February 28, 2024 19:06
@xiangjingli @stevekuznetsov
rosa: add etcdEncryption, tags
27cfdc5 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
rosa: support PrivateLink
8dc29e5 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from stevekuznetsov. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 29, 2024
This was referenced Feb 29, 2024
Closed
Closed
@stevekuznetsov stevekuznetsov changed the title rosa: add missing fields to spec ✨ rosa: add missing fields to spec Feb 29, 2024
@stevekuznetsov
rosa: expose tag validation error
d3048af 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@stevekuznetsov stevekuznetsov force-pushed the skuznets/tags-etcd branch 2 times, most recently from edd4767 to 999a841 Compare February 29, 2024 14:26
@stevekuznetsov
Copy link
Contributor Author

/hold cancel

We are using a set of status conditions to expose errors now.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@stevekuznetsov stevekuznetsov force-pushed the skuznets/tags-etcd branch 2 times, most recently from 9ae7ed0 to a968273 Compare February 29, 2024 15:56
@stevekuznetsov
rosa: expose errors in status
ce07e08 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiangjingli
Copy link
Contributor

@stevekuznetsov @muraee

The PR has not implemented the AdditionalTags,EtcdEncryptionKMSArn and Private in the rosa controlplane controller

Are we going to to push more code to the PR or create a new PR?

For the ref, here is how AdditionalTags,EtcdEncryptionKMSArn are implemented

image

https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4802/files

@muraee
Copy link
Contributor

muraee commented Mar 5, 2024

@xiangjingli #4844 includes your changes.
/close

@k8s-ci-robot
Copy link
Contributor

@muraee: Closed this PR.

In response to this:

@xiangjingli #4844 includes your changes.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muraee muraee muraee left review comments

@vincepri vincepri vincepri left review comments

@cnmcavoy cnmcavoy Awaiting requested review from cnmcavoy

@faiq faiq Awaiting requested review from faiq

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevekuznetsov @k8s-ci-robot @xiangjingli @muraee @vincepri