Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 chore: update owners #5137

Merged
merged 1 commit into from
Oct 22, 2024
Merged

🌱 chore: update owners #5137

merged 1 commit into from
Oct 22, 2024

Conversation

richardcase
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This updates the owners (and aliases) to reduce unecessary notifcations and review requests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 7, 2024
@k8s-ci-robot k8s-ci-robot requested review from damdo and faiq October 7, 2024 13:05
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2024
@richardcase richardcase added kind/support Categorizes issue or PR as a support question. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 7, 2024
@richardcase richardcase changed the title chore: update owners 🌱 chore: update owners Oct 7, 2024
@damdo
Copy link
Member

damdo commented Oct 7, 2024

Was this a request in one of the community meetings?

@richardcase
Copy link
Member Author

Was this a request in one of the community meetings?

It was mainly from a slack message that got me thinking. Perhaps a better option is keeping SCL leads & CAPI maintainers but remove CAPI reviewers? The idea being to reduce the notifications and unecessay assigments of PRs to people.

@richardcase
Copy link
Member Author

A good topic for next weeks office hours?

@richardcase
Copy link
Member Author

Until its been discussed:

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2024
AndiDog
AndiDog reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I can't join today's office hours:

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@richardcase
chore: update owners
ddffa5a 
This updates the owners (and aliases) to reduce unecessary notifcations
and review requests.

Signed-off-by: Richard Case <richard.case@outlook.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@AndiDog
Copy link
Contributor

AndiDog commented Oct 21, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2024
@faiq
Copy link
Contributor

faiq commented Oct 21, 2024

/lgtm

@faiq faiq removed their assignment Oct 21, 2024
@richardcase
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@richardcase
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit b99a49c into kubernetes-sigs:main Oct 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndiDog AndiDog AndiDog left review comments

@damdo damdo Awaiting requested review from damdo

@faiq faiq Awaiting requested review from faiq

Assignees

@AndiDog AndiDog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardcase @damdo @AndiDog @faiq @k8s-ci-robot