Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 fix: run ami builds sequentially #5145

Merged

Conversation

richardcase
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Change the AMI build workflow to run the matrix entries sequentially instead of all parallel. This should stop them getting cancelled due to exceeding resource limits.

Fail fast has also been set to false so that if one of the metrix jobs fails the others continue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

Change the AMI build workflow to run the matrix entries sequentially
instead of all parallel. This should stop them getting cancelled due
to exceeding resource limits.

Fail fast has also been set to false so that if one of the metrix jobs
fails the others continue.

Signed-off-by: Richard Case <richard.case@outlook.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from richardcase. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cnmcavoy and damdo October 9, 2024 06:38
@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2024
@richardcase
Copy link
Member Author

All checks are passing, using admin to directly merge to expedite the AMI publication,

@richardcase richardcase merged commit a36900a into kubernetes-sigs:main Oct 9, 2024
19 of 21 checks passed
@richardcase richardcase deleted the ami_workflow_sequentialjobs branch October 9, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants