🐛 Improve clustermodule existence check

[rikatz]

What this PR does / why we need it:
NodeAntiAffinity uses an api called clustermodules. This API does not have a "GET" operation, which means that checking it existence needs to do a list and iterate over this list, being an expensive operation.

But the "membership" API, part of clustermodules does have a Get members that, in case of the clustermodule not existing, will throw a 404 error.

Using this check instead may help improving the usage of clustermodules on large environments.

Note from Ricardo I'm testing this PR locally on a place I have found this to be a problem :) Will post more information soon - This works really fine and the consumption of rest endpoint has felt a lot!

[sbueringer]

/hold

Just to merge the logging PR first

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (83f9509) 63.59% compared to head (94356e1) 63.83%.
Report is 9 commits behind head on main.

Files	Patch %	Lines
pkg/services/govmomi/clustermodules/provider.go	54.54%	4 Missing and 1 partial ⚠️
pkg/services/govmomi/service.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
+ Coverage   63.59%   63.83%   +0.24%     
==========================================
  Files         120      119       -1     
  Lines        8685     8678       -7     
==========================================
+ Hits         5523     5540      +17     
+ Misses       2735     2718      -17     
+ Partials      427      420       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rikatz]

ok, will wait for a new govmomi version to bump here :)

[sbueringer]

/hold cancel

logging PR is merged

[rikatz]

/hold
Will bump https://github.com/vmware/govmomi/releases/tag/v0.34.0 tomorrow and use new error check util func

[rikatz]

all done, I've kept the commits separated to easy the review, let me know when to squash it :)

[sbueringer]

Last nit: https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/2535/files#r1425328351

Feel free to squash directly

[rikatz]

/hold cancel

[sbueringer]

/approve

/assign @chrischdi
for final review

@rikatz Would be probably nice to cherry-pick into 1.8 / 1.7?

[sbueringer]

/test pull-cluster-api-provider-vsphere-e2e-full-main

[rikatz]

@sbueringer yeah, on my side we are using CAPV 1.8 so would be great, but also I'm happy to cherrypick to v1.7 (if everything fails here due to rebases, I can do it manually!)

[chrischdi]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c3e8ed5603204716376ec0a0895599ad6e7f6912

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

Sounds good, thank you!

I think automatic cherry-pick will fail because of the logging changes (I think you had to rebase after the logging PR was merged)

[chrischdi]

/retest

[k8s-ci-robot]

@rikatz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-vsphere-apidiff-main	94356e1	link	false	/test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.