🌱 Remove reconcile when APIserver is online in VSphereCluster controller #2551
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign @chrischdi @fabriziopandini /cc @rikatz |
| @@ -223,25 +220,6 @@ func (r *clusterReconciler) reconcileNormal(ctx context.Context, clusterCtx *cap | |||
|
|
|||
| clusterCtx.VSphereCluster.Status.Ready = true | |||
|
|
|||
There was a problem hiding this comment.
There is nothing (anymore) in the Reconcile func that depends on the wl cluster APIserver being online
(this was different in previous versions where this controller deployed CCM/CSI)
|
/test pull-cluster-api-provider-vsphere-e2e-full-main |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
- Coverage 63.58% 63.10% -0.49%
==========================================
Files 120 120
Lines 8685 8599 -86
==========================================
- Hits 5522 5426 -96
- Misses 2735 2745 +10
Partials 428 428 ☔ View full report in Codecov by Sentry. |
|
Very nice cleanup. The e2e-full-main tests already run 👍 /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5cb08208b021f995e7f4b523a0de6f5673c17d23
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
See #2465 (comment)
Kudos to @chrischdi for the nice research!!
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2465