Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 controllers: add unit test coverage for esxi host label on supervisor #3085

Merged
merged 1 commit into from
Jul 2, 2024
Merged

🌱 controllers: add unit test coverage for esxi host label on supervisor #3085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions controllers/vmware/test/controllers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ import (
vmwarev1 "sigs.k8s.io/cluster-api-provider-vsphere/apis/vmware/v1beta1"
"sigs.k8s.io/cluster-api-provider-vsphere/controllers"
vmwarewebhooks "sigs.k8s.io/cluster-api-provider-vsphere/internal/webhooks/vmware"
"sigs.k8s.io/cluster-api-provider-vsphere/pkg/constants"
capvcontext "sigs.k8s.io/cluster-api-provider-vsphere/pkg/context"
"sigs.k8s.io/cluster-api-provider-vsphere/pkg/manager"
)
Expand Down Expand Up @@ -672,12 +673,26 @@ var _ = Describe("Reconciliation tests", func() {
}
newVM.Status.Network.PrimaryIP4 = "1.2.3.4"
newVM.Status.BiosUUID = "test-bios-uuid"
newVM.Status.Host = "some-esxi-host"
return k8sClient.Status().Update(ctx, newVM)
}, time.Second*30).Should(Succeed())

By("Expect the VSphereMachine VM status to reflect VM Ready status")
assertEventuallyVMStatus(infraMachineKey, infraMachine, vmwarev1.VirtualMachineStateReady)

By("Expect the Machine's label to reflect the ESXi host")
EventuallyWithOffset(1, func() (string, error) {
if err := k8sClient.Get(ctx, machineKey, machine); err != nil {
return "", err
}
v, ok := machine.GetLabels()[constants.ESXiHostInfoLabel]
if !ok {
return "", fmt.Errorf("expect machine to have label %s", constants.ESXiHostInfoLabel)
}

return v, nil
}, time.Second*30, time.Millisecond*500).Should(Equal("some-esxi-host"))

// In the case of a LoadBalanced endpoint, ControlPlaneEndpoint is a
// load-balancer Testing load-balanced endpoints is done in
// control_plane_endpoint_test.go
Expand Down