Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add ability to add new data disks to VM during clone process #3214

Merged
merged 3 commits into from
Dec 23, 2024
Merged

✨ Add ability to add new data disks to VM during clone process #3214

merged 3 commits into from
Dec 23, 2024

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Oct 3, 2024

What this PR does / why we need it:
Add API changes that adds the ability to add new data disks to VMs during the cloning process. These new disks are not present in the vSphere VM Template.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3213

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @vr4manta!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @vr4manta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 3, 2024
@chrischdi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 4, 2024
@chrischdi
Copy link
Member

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

This was referenced Oct 9, 2024
Closed
Closed
neolit123
neolit123 reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ping once this is ready for review.

@vr4manta vr4manta force-pushed the multi_disk branch 7 times, most recently from 9c0f201 to 1636c16 Compare October 17, 2024 18:13
@vr4manta
Copy link
Contributor Author

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

@vr4manta vr4manta marked this pull request as ready for review October 17, 2024 19:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
@vr4manta
Copy link
Contributor Author

@neolit123
This is ready to start reviewing.

@vr4manta vr4manta force-pushed the multi_disk branch 2 times, most recently from e85ee10 to fd1aaee Compare November 26, 2024 20:41
chrischdi
chrischdi reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I think that's the last round for me :-)

Sorry for the big suggestion, that escalated a bit quickly on my side 😂

pkg/services/govmomi/vcenter/clone.go Outdated Show resolved Hide resolved
pkg/services/govmomi/vcenter/clone.go Outdated Show resolved Hide resolved
pkg/services/govmomi/vcenter/clone.go Outdated Show resolved Hide resolved
test/e2e/data/infrastructure-vsphere-govmomi/main/multi-disk/data-disks-patch.yaml Outdated Show resolved Hide resolved
@chrischdi
Copy link
Member

Big Kudos for the e2e test! That's a very efficient one and also easy to understand!

@vr4manta
Copy link
Contributor Author

vr4manta commented Dec 5, 2024

Big Kudos for the e2e test! That's a very efficient one and also easy to understand!

Thanks!

@vr4manta
Copy link
Contributor Author

vr4manta commented Dec 5, 2024

Looks great, I think that's the last round for me :-)

Sorry for the big suggestion, that escalated a bit quickly on my side 😂

No problem. I do like making it an object that maintains the state. I've made the changes and am testing more thoroughly.

@chrischdi
Copy link
Member

I'm good with the change! Let's get this over the finish line :-)

@chrischdi
Copy link
Member

/approve

I'm okay to merge this.

Just want to give @neolit123 or @rikatz a chance if they want to take a look before merging.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@chrischdi
Copy link
Member

Setting lazy consensus by end of week :-)

@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fd1d6ca68263ef6b3b6fb02f4b647188cc5367cb

@k8s-ci-robot k8s-ci-robot merged commit 2880c92 into kubernetes-sigs:main Dec 23, 2024
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@neolit123 neolit123 neolit123 left review comments

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

@zhanggbj zhanggbj Awaiting requested review from zhanggbj

Assignees

@neolit123 neolit123

@chrischdi chrischdi

@lubronzhan lubronzhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

Add data disks not present in VM template to VM during cloning
5 participants
@vr4manta @k8s-ci-robot @chrischdi @neolit123 @lubronzhan