Skip to content

🌱 templates: remove cloud-provider flag for kube-apiserver due to removal in v1.33 #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

xref: kubernetes/kubernetes#130162

Without this, the templates used (also in CI) set the flag --cloud-provider=external, leading to apiserver not starting due to unknown flag.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2025
@chrischdi
Copy link
Member Author

/cherry-pick release-1.12

So if we cut a patch release, users use templates which are upgradable.

@k8s-infra-cherrypick-robot

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

So if we cut a patch release, users use templates which are upgradable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member Author

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2025
@chrischdi chrischdi force-pushed the pr-fix-v1-33-cloud-provider-flag-removal branch from 8164f7c to cb6b212 Compare February 25, 2025 13:25
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2025
@chrischdi chrischdi force-pushed the pr-fix-v1-33-cloud-provider-flag-removal branch 2 times, most recently from 9741c36 to 9100a2a Compare February 25, 2025 14:11
@chrischdi chrischdi force-pushed the pr-fix-v1-33-cloud-provider-flag-removal branch from 9100a2a to b2a9485 Compare February 25, 2025 14:41
@kubernetes-sigs kubernetes-sigs deleted a comment from sbueringer Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 25, 2025
@chrischdi chrischdi changed the title 🌱 templates: remove cloud-provider flag due to removal in v1.33 🌱 templates: remove cloud-provider flag due to removal in v1.33 and drop server and thumbprint from VSphereMachineTemplates Feb 25, 2025
@chrischdi chrischdi force-pushed the pr-fix-v1-33-cloud-provider-flag-removal branch from b2a9485 to 772e0b8 Compare February 25, 2025 14:57
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2025
@sbueringer
Copy link
Member

Changes look fine, assuming CI gets green + please update the PR title according to the recent changes

/lgtm
/approve

Keeping the hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ee6326d937c20931a873d9d9ef2288153aba8c1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
@chrischdi chrischdi changed the title 🌱 templates: remove cloud-provider flag due to removal in v1.33 and drop server and thumbprint from VSphereMachineTemplates 🌱 templates: remove cloud-provider flag due to removal in v1.33 Feb 25, 2025
@chrischdi chrischdi changed the title 🌱 templates: remove cloud-provider flag due to removal in v1.33 🌱 templates: remove cloud-provider flag for kube-apiserver due to removal in v1.33 Feb 25, 2025
@chrischdi
Copy link
Member Author

/hold cancel

ci green

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 62e2b32 into kubernetes-sigs:main Feb 25, 2025
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Feb 25, 2025
@k8s-infra-cherrypick-robot

@chrischdi: new pull request created: #3366

In response to this:

/cherry-pick release-1.12

So if we cut a patch release, users use templates which are upgradable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants