-
Notifications
You must be signed in to change notification settings - Fork 302
🌱 templates: remove cloud-provider flag for kube-apiserver due to removal in v1.33 #3365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 templates: remove cloud-provider flag for kube-apiserver due to removal in v1.33 #3365
Conversation
/cherry-pick release-1.12 So if we cut a patch release, users use templates which are upgradable. |
@chrischdi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8164f7c
to
cb6b212
Compare
9741c36
to
9100a2a
Compare
9100a2a
to
b2a9485
Compare
b2a9485
to
772e0b8
Compare
Changes look fine, assuming CI gets green + please update the PR title according to the recent changes /lgtm Keeping the hold |
LGTM label has been added. Git tree hash: 8ee6326d937c20931a873d9d9ef2288153aba8c1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel ci green |
@chrischdi: new pull request created: #3366 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
xref: kubernetes/kubernetes#130162
Without this, the templates used (also in CI) set the flag
--cloud-provider=external
, leading to apiserver not starting due to unknown flag.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #