Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding imagefsinfo endpoint for both container and image filesystems #1295

Merged
merged 1 commit into from
Dec 4, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 28 additions & 19 deletions cmd/crictl/image.go
Original file line number Diff line number Diff line change
Expand Up @@ -494,28 +494,37 @@ var imageFsInfoCommand = &cli.Command{
if err != nil {
return fmt.Errorf("image filesystem info request: %w", err)
}
for _, info := range r.ImageFilesystems {
status, err := protobufObjectToJSON(info)
if err != nil {
return fmt.Errorf("marshal image filesystem info to json: %w", err)
}
fileSystemReport := func(filesystem []*pb.FilesystemUsage) error {
for _, info := range filesystem {
status, err := protobufObjectToJSON(info)
if err != nil {
return fmt.Errorf("marshal filesystem info to json: %w", err)
}

switch output {
case "json", "yaml", "go-template":
if err := outputStatusInfo(status, nil, output, tmplStr); err != nil {
return fmt.Errorf("output image filesystem info: %w", err)
switch output {
case "json", "yaml", "go-template":
if err := outputStatusInfo(status, nil, output, tmplStr); err != nil {
return fmt.Errorf("output filesystem info: %w", err)
}
continue
case "table": // table output is after this switch block
default:
return fmt.Errorf("output option cannot be %s", output)
}
continue
case "table": // table output is after this switch block
default:
return fmt.Errorf("output option cannot be %s", output)
}

// otherwise output in table format
fmt.Printf("TimeStamp: %d\n", info.Timestamp)
fmt.Printf("Disk: %s\n", units.HumanSize(float64(info.UsedBytes.GetValue())))
fmt.Printf("Inodes: %d\n", info.InodesUsed.GetValue())
fmt.Printf("Mountpoint: %s\n", info.FsId.Mountpoint)
// otherwise output in table format
fmt.Printf("TimeStamp: %d\n", info.Timestamp)
fmt.Printf("Disk: %s\n", units.HumanSize(float64(info.UsedBytes.GetValue())))
fmt.Printf("Inodes: %d\n", info.InodesUsed.GetValue())
fmt.Printf("Mountpoint: %s\n", info.FsId.Mountpoint)
}
return nil
}
if err := fileSystemReport(r.ImageFilesystems); err != nil {
return err
}
if err := fileSystemReport(r.ContainerFilesystems); err != nil {
return err
}

return nil
Expand Down
Loading