Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When use crictl rmp -a -f, Avoid excessive coroutines causing context… #1749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

When use crictl rmp -a -f, Avoid excessive coroutines causing context… #1749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading status checks…
When use crictl rmp -a -f, Avoid excessive coroutines causing context… 
… timeout

Increase the maximum number of co processes limit

Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
@jokemanfire
jokemanfire committed Jan 16, 2025
commit 673bfe15b5c0c8f7c696b4848945d2bc98ac4fe7
5 changes: 5 additions & 0 deletions cmd/crictl/sandbox.go
View file
Original file line number Diff line number Diff line change
@@ -166,8 +166,13 @@ var removePodCommand = &cli.Command{
}

funcs := []func() error{}
// set max concurrency to 10, to avoid too many goroutines
maxConcurrency := 10
sem := make(chan struct{}, maxConcurrency)
for _, id := range ids {
funcs = append(funcs, func() error {
sem <- struct{}{}
defer func() { <-sem }()
resp, err := InterruptableRPC(nil, func(ctx context.Context) (*pb.PodSandboxStatusResponse, error) {
return runtimeClient.PodSandboxStatus(ctx, id, false)
})