Deflake e2e test should not show help running rmi -a
#1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
e2e-deflake
branch
2 times, most recently
from
00c91b2 to
16cf233
Compare
saschagrunert
changed the title
should not show help running rmi -ashould not show help running rmi -a
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
1 similar comment
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
test/e2e/inspect_test.go
Outdated
| @@ -55,7 +55,7 @@ var _ = t.Describe("inspect", func() { | |||
|
|
|||
| AfterEach(func() { | |||
| Expect(t.Crictl("rmp -f " + sandbox)).To(Exit(0)) | |||
| Expect(t.Crictl("rmi " + imageLatest)).To(Exit(0)) | |||
| Expect(t.Crictl("rmi -a")).To(Exit(0)) | |||
There was a problem hiding this comment.
will it affect any other tests this way? Anything that needs images and running in-parallel would be affected?
There was a problem hiding this comment.
Yes, I'll adapt the tests to only remove the images being used as well as the pause image. I change the other tests according to this as well.
The problem is that the other `inspect` test may have the pause image hanging around depending on the runtime configuration. We fix this by removing all images during the `inspect` suite. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
e2e-deflake
branch
from
16cf233 to
41fe74d
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
The problem is that the other
inspecttest may have the pause image hanging around depending on the runtime configuration. We fix this by removing all images during theinspectsuite.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?