chore(filter-tags): pre-process filter tags #5063
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
ivankatliarchuk
changed the title
|
Pretty sure it is a bug, I can’t think of legitimate use cases. It’s true that it would be a potential breaking change, so I’d love to make sure that it gets mentioned in the release notes of the next release. |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
I mention this in |
|
/retest |
|
I think we can merge it now. @ivankatliarchuk Can you retrigger the go/build ci ? maybe with git push on a no edit commit ? |
* master: test(domain-filter): simple filters on domain exclusion (kubernetes-sigs#5064) chore(deps): bump nosborn/github-action-markdown-cli ci(docs): add markdown linters and editorconfig (kubernetes-sigs#5055) docs: update and refactor contribution part (kubernetes-sigs#5073) fix(chart): update rbac for F5 transportserver source (kubernetes-sigs#5066) fix(chart): non-string types on svcaccount annotations (kubernetes-sigs#5067) Update aws.md fix: expand tabs in ClouDNS entry fix alignment feat(docs): add ClouDNS webhook provider to readme chore(deps): bump the dev-dependencies group across 1 directory with 22 updates
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
Done. Rebased with master just in case |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Description
This is a follow-up for a pull request #5060
In previous pull-request, I found a side effect for tags filter where Tag has no Key but only value set.
For me it looks like a bug that could be a feature. Let me know if it should be supported. I've actually added the test to highlight this in previous pull request. If we keep the behaviour where key is empty and value is provided, I'll update the documentation and logic
Design of actual pre-processing was discussed here #5042
Checklist