Skip to content

Conversation

@rickliujh
Copy link

Summary

This PR fixes issue when using externalSecrets in Values.yaml, Helm Charts, useAccessToken has not affect, in cluster setup

Related Issue

Fixes #3954

Steps to Test

testing if "-oidc-use-access-token=$(OIDC_USE_ACCESS_TOKEN)" is set when config.oidc.useAccessToken or config.env OIDC_USE_ACCESS_TOEKN is set to true

  1. use default Values.yaml file, set externalSecrets.enable to true and secrets.create to false
  2. add config.oidc.useAccessToken: true
config:
  inCluster: true
  baseURL: ""
  oidc:
    secret:
      create: false
    externalSecret:
      enabled: true
      name: "oidc"
    useAccessToken: true
  1. run helm --release-name headlamp template . >all.yaml, and see if "-oidc-use-access-token=$(OIDC_USE_ACCESS_TOKEN)" is set for containers args in headlamp deployment
  2. remove config.oidc.useAccessToken, set OIDC_USE_ACCESS_TOKEN at env
config:
  inCluster: true
  baseURL: ""
  oidc:
    secret:
      create: false
    externalSecret:
      enabled: true
      name: "oidc"
env:
  - name: OIDC_USE_ACCESS_TOKEN
    value: "true"
  1. repeat step 3

Screenshots (if applicable)

image

Notes for the Reviewer

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 3, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: rickliujh / name: Rick L. (1b3eb41)

@k8s-ci-robot k8s-ci-robot requested review from illume and skoeva November 3, 2025 21:29
@k8s-ci-robot
Copy link
Contributor

Welcome @rickliujh!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 3, 2025
@illume illume added this to the v0.38.0 milestone Nov 4, 2025
@illume illume added the charts label Nov 4, 2025
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rickliujh, skoeva
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm Chart - Unable to set OIDC Access Token flag when using external secret

4 participants