charts: fix useAccessToken arg not set when using external secrets #4122
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue when using externalSecrets in Values.yaml, Helm Charts, useAccessToken has not affect, in cluster setup
Related Issue
Fixes #3954
Steps to Test
testing if "-oidc-use-access-token=$(OIDC_USE_ACCESS_TOKEN)" is set when config.oidc.useAccessToken or config.env OIDC_USE_ACCESS_TOEKN is set to true
helm --release-name headlamp template . >all.yaml, and see if "-oidc-use-access-token=$(OIDC_USE_ACCESS_TOKEN)" is set for containers args in headlamp deploymentScreenshots (if applicable)
Notes for the Reviewer