Support for acadia profile #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
arahamad
approved these changes
Dec 2, 2024
| @@ -65,7 +69,8 @@ func getRequestedCapacity(capRange *csi.CapacityRange) (int64, error) { | |||
|
|
|||
| // Limit is more than Required, but larger than Minimum. So we just set capcity to Minimum | |||
| // Too small, default | |||
| if capBytes < utils.MinimumVolumeSizeInBytes { | |||
| // If profile is SDP profile then no need to check for minimum size as the RoundUpBytes will giving minimum value as 1 GiB | |||
| if profileName != SDPProfile && capBytes < utils.MinimumVolumeSizeInBytes { | |||
| expectedValue int64 | ||
| expectedError error | ||
| }{ | ||
| { | ||
| testCaseName: "Check minimum size supported by volume provider in case of nil passed as input for sdp profile", |
There was a problem hiding this comment.
please add negative tests as well
There was a problem hiding this comment.
Added few cases covering nil but we cannot pass negative value to this parameter. IDeally this will come from the k8s parsing form PVC.It is not allowed
k8s-ci-robot
added
the
approved
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
sameshai
force-pushed
the
acadia-support
branch
from
079865c to
b13652b
Compare
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
arahamad
requested changes
Dec 2, 2024
k8s-ci-robot
removed
the
approved
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
arahamad
requested changes
Dec 2, 2024
| for key, value := range req.GetParameters() { | ||
| switch key { | ||
| case Profile: | ||
| if utils.ListContainsSubstr(SupportedProfile, value) { | ||
| profileName = value |
There was a problem hiding this comment.
why we can't use volume.VPCVolume.Profile.Name instead of creating new variable?
There was a problem hiding this comment.
@arahamad I had initially used that only but wanted to avoid multiple nil checks. I have now put generic nil check to avoid this. Thanks for the comments.
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
arahamad
approved these changes
Dec 3, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arahamad, sameshai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.