Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for update Volume tags via RIAAS #212

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Support for update Volume tags via RIAAS #212

merged 5 commits into from
Jan 30, 2025

Conversation

sameshai
Copy link
Contributor

@sameshai sameshai commented Jan 29, 2025 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 29, 2025
@sameshai sameshai self-assigned this Jan 29, 2025
@coveralls
Copy link

coveralls commented Jan 29, 2025 •
edited
Loading

Coverage Status

coverage: 80.144%. remained the same
when pulling a3d04bf on sameshai:v5.1updateVolume
into 398e155 on kubernetes-sigs:v5.1.

prankulmahajan
prankulmahajan reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@prankulmahajan prankulmahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2025
arahamad
arahamad approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@arahamad arahamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

please verify these changes like master branch, going forward lets come up with approach to that new feature will be added to new version only

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arahamad, sameshai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit ad9d3f2 into kubernetes-sigs:v5.1 Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prankulmahajan prankulmahajan prankulmahajan left review comments

@arahamad arahamad arahamad approved these changes

@ambiknai ambiknai Awaiting requested review from ambiknai

@bradtopol bradtopol Awaiting requested review from bradtopol

Assignees

@sameshai sameshai

@prankulmahajan prankulmahajan

@arahamad arahamad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sameshai @coveralls @k8s-ci-robot @prankulmahajan @arahamad