Cache taints for existing nodes

pkg/controllers/provisioning/scheduling/existingnode.go

@@ -31,6 +31,7 @@ import (
 type ExistingNode struct {
 	*state.StateNode
 	cachedAvailable v1.ResourceList // Cache so we don't have to re-subtract resources on the StateNode every time
+	cachedTaints    []v1.Taint      // Cache so we don't hae to re-construct the taints each time we attempt to schedule a pod
 
 	Pods         []*v1.Pod
 	topology     *Topology
@@ -54,6 +55,7 @@ func NewExistingNode(n *state.StateNode, topology *Topology, daemonResources v1.
 	node := &ExistingNode{
 		StateNode:       n,
 		cachedAvailable: n.Available(),
+		cachedTaints:    n.Taints(),
 		topology:        topology,
 		requests:        remainingDaemonResources,
 		requirements:    scheduling.NewLabelRequirements(n.Labels()),
@@ -65,7 +67,7 @@ func NewExistingNode(n *state.StateNode, topology *Topology, daemonResources v1.
 
 func (n *ExistingNode) Add(ctx context.Context, kubeClient client.Client, pod *v1.Pod, podRequests v1.ResourceList) error {
 	// Check Taints
-	if err := scheduling.Taints(n.Taints()).Tolerates(pod); err != nil {
+	if err := scheduling.Taints(n.cachedTaints).Tolerates(pod); err != nil {
 		return err
 	}
 	// determine the volumes that will be mounted if the pod schedules

pkg/scheduling/requirements.go

@@ -118,6 +118,10 @@ func HasPreferredNodeAffinity(p *corev1.Pod) bool {
 }
 
 func (r Requirements) NodeSelectorRequirements() []v1.NodeSelectorRequirementWithMinValues {
+	ret := []v1.NodeSelectorRequirementWithMinValues{}
+	for _, requirement := range r {
+		return requirement.NodeSelectorRequirement()
+	}
 	return lo.Map(lo.Values(r), func(req *Requirement, _ int) v1.NodeSelectorRequirementWithMinValues {
 		return req.NodeSelectorRequirement()
 	})