chore: Add reconcile_id to scheduling metrics
#1951
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Pull Request Test Coverage Report for Build 13083424436Details
💛 - Coveralls |
jonathan-innis
changed the title
reconcile-id rather than the scheduler-idreconcile-id to metrics
jonathan-innis
force-pushed
the
use-reconcile-id-scheduler
branch
3 times, most recently
from
db57f18 to
f43e2ff
Compare
jonathan-innis
force-pushed
the
use-reconcile-id-scheduler
branch
from
f43e2ff to
0c03111
Compare
jonathan-innis
changed the title
reconcile-id to metricsreconcile-id to scheduling metrics
jonathan-innis
changed the title
reconcile-id to scheduling metricsreconcile_id to scheduling metrics
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
This change adds
reconcile_idto our prometheus metrics in the scheduler for correlating scheduling loops with provisioning/disruptionHow was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.