Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release new version v0.0.5 of view-cert #3741

Conversation

krew-release-bot
Copy link
Contributor

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v0.0.5 of view-cert on behalf of @mlorenzo-stratio.

Thanks,
@krew-release-bot

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2024
@ahmetb
Copy link
Member

ahmetb commented Apr 11, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/view-cert.yaml is not a straightforward version bump: change on line 4 does not seem like a version bump: [- homepage: https://github.com/lmolas/kubectl-view-cert]
/kind plugin-update

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krew-release-bot
Once this PR has been reviewed and has the lgtm label, please assign chriskim06 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/plugin-update Version or manifest updates for existing plugins label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot requested a review from chriskim06 April 11, 2024 12:37
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 11, 2024
@ahmetb
Copy link
Member

ahmetb commented Apr 19, 2024

/close
Repo seems to have changed?

@k8s-ci-robot
Copy link
Contributor

@ahmetb: Closed this PR.

In response to this:

/close
Repo seems to have changed?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ml0renz0
Copy link

@ahmetb it seems the original repo maintainer is not so active lately lmolas/kubectl-view-cert#3

@ahmetb
Copy link
Member

ahmetb commented Apr 19, 2024

I Recommend contacting the maintainer and getting a permission from them for this transfer. We treat this as users implicitly establish a trust between the maintainer when they install an untrusted plugin from the repo, so changing the maintainer without their consent is not ideal.

@ml0renz0
Copy link

I'll try. Anyways I just wanted to add some features on my fork and released a new version for my personal use, didn't mean to release a new version of this plugin on krew at all, but it seems it was all configured this way in @lmolas repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants