Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chmod 0755 store/PLUGIN/VER dir #841

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Sep 13, 2023

Because we're doing mktemp (which gives 0700) and then moving it to $KREW_ROOT/store/PLUGIN/VERSION, we need to make sure that the directory is 0755 like the other dirs in store.

See #840.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2023
@ahmetb ahmetb force-pushed the ahmet/fix-store-chmod branch 2 times, most recently from fafb1e8 to 04a4bf0 Compare September 13, 2023 17:34
@ngoeddel-openi
Copy link

Excuse my impatience. When approximately can I expect the fix and in which version will it happen?

@ngoeddel-openi
Copy link

Can please someone add this lgtm label and remove do-not-merge/invalid-commit-message or what's the issue here?
Thank you!

Because we're doing `mktemp` (which gives 0700) and then moving it to
`$KREW_ROOT/store/PLUGIN/VERSION`, we need to make sure that the
directory is 0755 like the other dirs in `store`.
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 10, 2023
@chriskim06
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2e6cfb3 into kubernetes-sigs:master Nov 10, 2023
7 checks passed
@ngoeddel-openi
Copy link

@ahmetb May I ask when you will bring out a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants