Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Homebrew option for MacOS #858

Closed
wants to merge 1 commit into from

Conversation

kasadaamos
Copy link

Fixes #...
Related issue: #...

Copy link

linux-foundation-easycla bot commented Jun 25, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kasadaamos
Once this PR has been reviewed and has the lgtm label, please assign ahmetb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @kasadaamos!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 25, 2024
@ahmetb
Copy link
Member

ahmetb commented Jun 25, 2024

This is currently intentionally not documented, as Krew doesn't manage and update itself when installed via Homebrew. We also have no control or release automation for Homebrew at the moment. So this may require some thinking. But I'm not strongly against it.

@kasadaamos
Copy link
Author

kasadaamos commented Jun 26, 2024

This is currently intentionally not documented, as Krew doesn't manage and update itself when installed via Homebrew. We also have no control or release automation for Homebrew at the moment. So this may require some thinking. But I'm not strongly against it.

EDITED: Would it address the points you raise if I added them (these points) to the documentation in the proposed PR?

@kasadaamos
Copy link
Author

This isn't going anywhere, closing.

@kasadaamos kasadaamos closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants