Fix using same helm chart with different versions

[dlish]

Fixes #4813

When a helm chart version is specified it sets --untardir to include name-version i.e. charts/terraform-1.1.2.

If no version is specified the behavior stays the same in that it pulls the latest version with --untardir set to the charts directory ex.charts

Example

---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
helmCharts:
  - name: terraform
    releaseName: terraform-1
    namespace: terraform-1
    repo: https://helm.releases.hashicorp.com
  - name: terraform
    version: 1.1.1
    releaseName: terraform-2
    namespace: terraform-2
    repo: https://helm.releases.hashicorp.com
  - name: terraform
    version: 1.1.1
    releaseName: terraform-3
    namespace: terraform-3
    repo: https://helm.releases.hashicorp.com
  - name: terraform
    version: 1.1.2
    releaseName: terraform-4
    namespace: terraform-4
    repo: https://helm.releases.hashicorp.com

Running kustomize build --enable-helm produces the following in the charts directory

❯ tree -L 3 charts
charts
├── terraform
...
│   ├── Chart.yaml
...
│   ├── templates
...
│   └── values.yaml
├── terraform-1.1.1
│   ├── terraform
...
│   │   ├── Chart.yaml
...
│   │   ├── templates
...
│   │   └── values.yaml
│   └── terraform-1.1.1.tgz
├── terraform-1.1.2
│   ├── terraform
...
│   │   ├── Chart.yaml
...
│   │   ├── templates
...
│   │   └── values.yaml
│   └── terraform-1.1.2.tgz
└── terraform-1.1.2.tgz

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: dlish / name: Dustin Lish (893d637)

[k8s-ci-robot]

Welcome @dlish!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @dlish. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[natasha41575]

When a helm chart version is specified it sets --untardir to include name-version i.e. charts/terraform-1.1.2.

If no version is specified the behavior stays the same in that it pulls the latest version with --untardir set to the charts directory ex.charts

I have not looked at the code yet but this sounds like correct behavior and will fix #4813 in the same way that I'd imagined fixing it.

/triage accepted
/ok-to-test

/cc @koba1t @annasong20 could one of you give this a review?

[koba1t]

/assign koba1t

[dlish]

Looks like there's been a number of changes to the HelmChartInflationGenerator.go file since I initially opened. I'll work on getting this PR updated

[koba1t]

Looks like there's been a number of changes to the HelmChartInflationGenerator.go file since I initially opened. I'll work on getting this PR updated

Thanks!
I'll wait for your update.

/priority important-soon

[koba1t]

/kind bug

[annasong20]

/lgtm

[natasha41575]

/lgtm
/approve

Thank you so much for your contribution! Please feel free to reach out on the kubernetes slack if you are interested in picking up any other issues.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlish, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seh]

Did the behavior change here so that now kustomize always has Helm download a tar archive, even if the charts directory already exists, populated with the content of the tar archive? Before version 5.0.2, kustomize wouldn't try to download that archive again.

I find that if I download and then place the tar archive where helm pull would put it, then the command fails, because the file already exists.

[seh]

Ah, the Chart.yaml file now sits one directory component deeper, with the containing directory tree looking like the following:

charts
├── BUILD.bazel
└── minecraft-3.1.4
    └── minecraft
        ├── Chart.yaml
        ├── ...
        └── values.yaml

@dlish, what motivates repeating the chart name in the minecraft directory within the minecraft-3.1.4 directory?