-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest kube-opeapi to drop govalidator dependency #5825
Update to latest kube-opeapi to drop govalidator dependency #5825
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, but for some reason the bump in version is causing the linter to fail on already existing code 🤔
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7c4852e
to
f266228
Compare
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
f266228
to
84e6594
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.5.0` -> `v5.6.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary> ### [`v5.6.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.6.0) [Compare Source](kubernetes-sigs/kustomize@kustomize/v5.5.0...kustomize/v5.6.0) #### Announce This release introduces a unified internal package version (`v0.19.0`) across the entire kustomize repository. ref. kubernetes-sigs/kustomize#5800 #### Chore [#​5809](kubernetes-sigs/kustomize#5809): fix: "edit add labels" make labels handle -f flag same as commonLabels #### Dependencies [#​5825](kubernetes-sigs/kustomize#5825): Update to latest kube-opeapi to drop govalidator dependency [#​5830](kubernetes-sigs/kustomize#5830): downgrade go-difflib and go-spew to tagged releases [#​5837](kubernetes-sigs/kustomize#5837): Update kyaml to v0.19.0 [#​5839](kubernetes-sigs/kustomize#5839): Update cmd/config to v0.19.0 [#​5840](kubernetes-sigs/kustomize#5840): Update api to v0.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMzcuMSIsInVwZGF0ZWRJblZlciI6IjM5LjEzNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
xref: kubernetes/kube-openapi#518
xref: kubernetes/kube-openapi#512
xref: kubernetes/kubernetes#128573
We are looking to drop the
github.com/asaskevich/govalidator
as a dependency. To do this, we essentially ran the following commands in all the directories with a go.mod file as the latestkube-openapi
has a commit that removes this dependency.