🌱 Add experimental package and shared cache & informer implementation #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: SAP <mangirdas.judeikis@sap.com> Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
ntnn
reviewed
Jan 30, 2026
Comment on lines
+50
to
+52
| // The key uses the format <clusterName>|<namespace>/<name> unless <namespace> is empty, then | ||
| // it's just <clusterName>|<name>, and if no cluster annotation is present, | ||
| // it's just <namespace>/<name> or <name>. |
Member
There was a problem hiding this comment.
Is there something speaking against just using <clusterName>|<namespace>/<name> regardless of whether any of them are empty? Esp. when reading debug logs I think it could help make it clearer where a cache key came from.
Collaborator
Author
There was a problem hiding this comment.
dont think so, no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes a bit wild. This is an experimental package (
/exp) and an example that implements a shared cache & informer for use with multicluster-runtime.The benefit is that we enable memory and cross-cluster queries for the reconciler (see exp-kind-shared-cache).
In a way, this is currently not possible to be built using upstream client-go packages due to hardcoded KeyFunc usage (it's strange why we have those but we can't use them as they are not exposed :) )
90% of the code here is copied from the client-go tooling for informers and cache.
This is, in a way, idea seeding effort to see if people would find this useful