-
Notifications
You must be signed in to change notification settings - Fork 39
⚠️ improve capi provider #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: guilhem The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @guilhem! |
Signed-off-by: Guilhem Lettron <glettron@akamai.com>
embik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @guilhem, this is a great set of changes, thank you for bringing the CAPI provider more in line with the remaining providers in this repository. I have two comments.
In addition, I have a question: Your description has references (?) like F30844c7L94R94. What is that?
Thanks :) I jsut how to fix tests.
Copilot "tried" to generate a description |
Description
Key changes