Skip to content

Conversation

@guilhem
Copy link

@guilhem guilhem commented Feb 6, 2026

Description

  • Refactors the CAPI provider to be constructed without a manager and configured via an explicit SetupWithManager.
  • Adds kubeconfig hashing to detect changes and re-engage clusters when configs rotate.
  • Improves cluster lifecycle management (cache sync, removal, indexers) and simplifies the startup flow.

Key changes

  • Updates the example to build the provider first, then create the multi-cluster manager, and start a single manager instance.
  • The provider now:
    • reads raw kubeconfig bytes and parses locally,
    • detects kubeconfig changes via SHA-256,
    • re-engages clusters when kubeconfig changes,
    • tracks engaged clusters with RW locks and exposes list functionality.
  • Field indexers apply to existing and future clusters without holding locks during indexing.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: guilhem
Once this PR has been reviewed and has the lgtm label, please assign skitt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from embik and sttts February 6, 2026 18:17
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2026
@k8s-ci-robot
Copy link
Contributor

Welcome @guilhem!

It looks like this is your first PR to kubernetes-sigs/multicluster-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/multicluster-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2026
Signed-off-by: Guilhem Lettron <glettron@akamai.com>
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @guilhem, this is a great set of changes, thank you for bringing the CAPI provider more in line with the remaining providers in this repository. I have two comments.

In addition, I have a question: Your description has references (?) like F30844c7L94R94. What is that?

@guilhem
Copy link
Author

guilhem commented Feb 8, 2026

Hey @guilhem, this is a great set of changes, thank you for bringing the CAPI provider more in line with the remaining providers in this repository. I have two comments.

Thanks :)

I jsut how to fix tests.

In addition, I have a question: Your description has references (?) like F30844c7L94R94. What is that?

Copilot "tried" to generate a description
I changed to another

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants