Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Update sig storage lib external provisioner to v9.0.3 #358

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mengjiao-liu
Copy link

What this PR does / why we need it:

The previous PR #258 has not been updated for more than a year and has been closed.
#258 (comment)

The k/k test code requires nfs-subdir-external-provisioner to be updated to v8.0.0 +
kubernetes/kubernetes#114804 (comment)

Special notes for your reviewer:

The reason for not upgrading to the latest version v10.0.1 of sig-storage-lib-external-provisioner:
Because starting from v10.0.0, sig-storage-lib-external-provisioner added contextual logging. If we want to update to the latest version, all glog codes in this repository need to be updated to klog codes. I am not sure whether it is necessary to update, After all, it involves a lot of log content updates, which need to be discussed by the reviewer of nfs-subdir-external-provisioner.

Another way is to update it in a later PR.

/cc @yonatankahana @cornfeedhobo

I still need to test it on the cluster to make sure it works correctly, and when the test is complete, I will remove the WIP keyword.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu: GitHub didn't allow me to request PR reviews from the following users: cornfeedhobo.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

The previous PR #258 has not been updated for more than a year and has been closed.
#258 (comment)

The k/k test code requires nfs-subdir-external-provisioner to be updated to v8.0.0 +
kubernetes/kubernetes#114804 (comment)

Special notes for your reviewer:

The reason for not upgrading to the latest version v10.0.1 of sig-storage-lib-external-provisioner:
Because starting from v10.0.0, sig-storage-lib-external-provisioner added contextual logging. If we want to update to the latest version, all glog codes in this repository need to be updated to klog codes. I am not sure whether it is necessary to update, After all, it involves a lot of log content updates, which need to be discussed by the reviewer of nfs-subdir-external-provisioner.

Another way is to update it in a later PR.

/cc @yonatankahana @cornfeedhobo

I still need to test it on the cluster to make sure it works correctly, and when the test is complete, I will remove the WIP keyword.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mengjiao-liu
Once this PR has been reviewed and has the lgtm label, please assign wongma7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 4, 2024
@cornfeedhobo
Copy link

Thanks for taking this on! Is there any plan to update the helm chart version after this too? It seems to be stuck in time, even though the controller has been bumped up many times since the last helm release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants