allows controller to be configured via environment variable #31
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @Peac36! |
k8s-ci-robot
added
the
size/L
|
let's document this clearly and make sure we are consistent, IMHO flags should always be authoritative , since they are discoverable , environment variables are harder to find .. @mneverov your thoughts? |
Peac36
force-pushed
the
start-parsing-confing-from-env
branch
from
ec88908
to
1ad312e
Compare
Peac36
force-pushed
the
start-parsing-confing-from-env
branch
from
8eb02db
to
6399339
Compare
k8s-ci-robot
added
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mneverov, Peac36 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| c := logsapi.NewLoggingConfiguration() | ||
| logsapi.AddGoFlags(c, flag.CommandLine) | ||
| flag.Parse() | ||
|
|
||
| conf := config{EnableLeaderElection: true} |
There was a problem hiding this comment.
not familiar with this framework, does the library sets this to false if the flag is set and ignores it if the flag is not set @mneverov
There was a problem hiding this comment.
We discussed that by default the controller should run in leader election mode. The go-flags library does not have default values for boolean flags and suggests to use reverted flags like --disable-leader-election which will be on by default and can be overwritten.
To workaround this and provide the same flag semantics as in #20 @Peac36 added the line above such that if --enable-leader-election flag is not provided the controller will still run in leader election mode (again as before).
To disable leader election one can use --enable-leader-election=false.
There was a problem hiding this comment.
So the new library differentiate between flag not set and set to false
There was a problem hiding this comment.
When --enable-leader-election or --enable-leader-election=true are provided as well as when the flag is not provided at all the controller will start in leader election mode.
Disabling leader election is possible via --enable-leader-election=false
k8s-ci-robot
added
the
lgtm
Issue: #11