Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile ClusterCIDRs with Finalizers #37

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Reconcile ClusterCIDRs with Finalizers #37

wants to merge 4 commits into from
+31 −23

Commits on Sep 26, 2024

  1. Add check that finalizer is added to a newly created ClusterCIDR. 

    Run test cases in separate tests to improve visibility in test output.
    @mneverov
    mneverov committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    dbbf605 View commit details
    Browse the repository at this point in the history

  2. Fix log message: different messages for update and create.

    @mneverov
    mneverov committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3b62a51 View commit details
    Browse the repository at this point in the history

  3. go mod tidy

    @mneverov
    mneverov committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    20f9fad View commit details
    Browse the repository at this point in the history

  4. Always reconcile ClusterCIDRs even if a finalizer is present. Do not … 

    …append ClusterCIDRs if they are already present in the cidrMap which makes createClusterCIDR idempotent.
    @mneverov
    mneverov committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    708c9c4 View commit details
    Browse the repository at this point in the history