helmchart add imagepullsecrets

Signed-off-by: Lize Cai <lize.cai@sap.com>
kubernetes-sigs · Oct 25, 2024 · 5008c15 · 5008c15
1 parent 12ed490
commit 5008c15
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/helm/README.md b/helm/README.md
@@ -9,7 +9,7 @@ local-volume-provisioner in your Kubernetes with `helm install` directly.
 - [Install local-volume-provisioner with helm](#install-local-volume-provisioner-with-helm)
   - [Table of Contents](#table-of-contents)
   - [Install Helm](#install-helm)
-  - [Custom your deployment with values file](#custom-your-deployment-with-values-file)
+  - [Customize your deployment with values file](#customize-your-deployment-with-values-file)
   - [Install local-volume-provisioner](#install-local-volume-provisioner)
     - [Generate yaml files with `helm template` and install with `kubectl`](#generate-yaml-files-with-helm-template-and-install-with-kubectl)
     - [Install using helm repo](#install-using-helm-repo)
@@ -146,6 +146,7 @@ provisioner chart and their default values.
 | podLabels                               | Labels for each Pod in the DaemonSet.                                                                                          | map      | `-`                                                           |
 | image                                   | Provisioner image.                                                                                                             | str      | `registry.k8s.io/sig-storage/local-volume-provisioner:v2.5.0` |
 | imagePullPolicy                         | Provisioner DaemonSet image pull policy.                                                                                       | str      | `-`                                                           |
+| imagePullSecrets                        | Provisioner image pull secrets.                                                                                                | list     | `-`                                                           |
 | priorityClassName                       | Provisioner DaemonSet Pod Priority Class name.                                                                                 | str      | ``                                                            |
 | kubeConfigEnv                           | Specify the location of kubernetes config file.                                                                                | str      | `-`                                                           |
 | nodeLabels                              | List of node labels to be copied to the PVs created by the provisioner.                                                        | list     | `-`                                                           |

diff --git a/helm/provisioner/templates/daemonset_linux.yaml b/helm/provisioner/templates/daemonset_linux.yaml
@@ -31,6 +31,10 @@ spec:
       serviceAccountName: {{ template "provisioner.serviceAccountName" . }}
 {{- if .Values.priorityClassName }}
       priorityClassName: {{.Values.priorityClassName}}
+{{- end }}
+{{- if .Values.imagePullSecrets }}
+      imagePullSecrets:
+        {{ toYaml .Values.imagePullSecrets | nindent 8 }}
 {{- end }}
       nodeSelector:
         kubernetes.io/os: linux

diff --git a/helm/provisioner/templates/daemonset_windows.yaml b/helm/provisioner/templates/daemonset_windows.yaml
@@ -32,6 +32,10 @@ spec:
       serviceAccountName: {{ template "provisioner.serviceAccountName" . }}
 {{- if .Values.priorityClassName }}
       priorityClassName: {{.Values.priorityClassName}}
+{{- end }}
+{{- if .Values.imagePullSecrets }}
+      imagePullSecrets:
+        {{ toYaml .Values.imagePullSecrets | nindent 8 }}
 {{- end }}
       nodeSelector:
         kubernetes.io/os: windows

diff --git a/helm/provisioner/values.yaml b/helm/provisioner/values.yaml
@@ -100,6 +100,9 @@ image: registry.k8s.io/sig-storage/local-volume-provisioner:v2.6.0
 # Defines Image download policy, see kubernetes documentation for available values.
 # imagePullPolicy: Always
 
+# Defines Image pull secrets for the provisioner image.
+imagePullSecrets: []
+
 # Defines a name of the Pod Priority Class to use with the Provisioner DaemonSet
 # Note that if you want to make it critical, specify "system-cluster-critical"
 # or "system-node-critical" and deploy in kube-system namespace.