Skip to content

fix: Add permissions chart-release workflow #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sheyabernstein
Copy link
Contributor

@sheyabernstein sheyabernstein commented Jun 20, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes the chart release action so that new versions can be published and used.

Which issue(s) this PR fixes:

Fixes token permissions to the helm chart release action so that charts can be released without authentication errors.

Closes #496

Additional context:

  • Last actions run to release 2.8.8 failed (link)
  • azure/setup-helm no longer expects a token (link)

Special notes for your reviewer:

Release note:

none: re-run action for 2.8.8 release

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 20, 2025
Copy link

linux-foundation-easycla bot commented Jun 20, 2025

CLA Signed

  • ✅login: sheyabernstein / (a5a15b6)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 20, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @sheyabernstein!

It looks like this is your first PR to kubernetes-sigs/sig-storage-local-static-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-storage-local-static-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sheyabernstein. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 20, 2025
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 28, 2025
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, sheyabernstein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit eff422f into kubernetes-sigs:master Jun 30, 2025
12 checks passed
@sheyabernstein sheyabernstein deleted the fix/chart-release-action-config branch June 30, 2025 11:22
@sheyabernstein
Copy link
Contributor Author

Hey @andyzhangx, thanks for approving. Can this action be rerun to release the latest chart?

https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/actions/runs/14637113016

@andyzhangx
Copy link
Member

andyzhangx commented Jun 30, 2025

Hey @andyzhangx, thanks for approving. Can this action be rerun to release the latest chart?

https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/actions/runs/14637113016

I don't think so, a new PR needs to be created

@andyzhangx
Copy link
Member

helm chart is updated:
https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/releases/tag/local-static-provisioner-2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub API 403 when trying to release Helm chart
3 participants