Skip to content

docs: Update VPA update mode docs #8620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

docs: Update VPA update mode docs #8620

merged 1 commit into from
Oct 13, 2025
+3 −3

Conversation

ialidzhikov
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This PR:

  • denotes which is the default update mode
  • updates the feature state of InPlaceOrRecreate from alpha to beta
  • unifies the styling of update mode tags

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Oct 7, 2025
@ialidzhikov
Copy link
Contributor Author

/cc @vitanovs

@k8s-ci-robot
Copy link
Contributor

@ialidzhikov: GitHub didn't allow me to request PR reviews from the following users: vitanovs.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vitanovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-area labels Oct 7, 2025
@ialidzhikov ialidzhikov mentioned this pull request Oct 7, 2025
Merged
@adrianmoisey adrianmoisey changed the title docs: Update VPA udpate mode docs docs: Update VPA update mode docs Oct 7, 2025
@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@ialidzhikov
Copy link
Contributor Author

/cc @omerap12

@k8s-ci-robot k8s-ci-robot requested a review from omerap12 October 13, 2025 06:02
omerap12
omerap12 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, omerap12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@ialidzhikov
Copy link
Contributor Author

/test pull-autoscaling-e2e-vpa-full

1 similar comment
@ialidzhikov
Copy link
Contributor Author

/test pull-autoscaling-e2e-vpa-full

@ialidzhikov
Copy link
Contributor Author

@adrianmoisey , @omerap12 , do you know why pull-autoscaling-e2e-vpa-full fails?

@adrianmoisey
Copy link
Member 

...........................................�[0;31mCluster failed to initialize within 300 seconds.
Last output from querying API server follows:
-----------------------------------------------------
*   Trying 34.42.155.89:443...
* Connection timed out after 5001 milliseconds
* Closing connection 0
curl: (28) Connection timed out after 5001 milliseconds

At a guess, that's an infra problem

/test pull-autoscaling-e2e-vpa-full

@adrianmoisey
Copy link
Member

/test pull-autoscaling-e2e-vpa-full

@omerap12
Copy link
Member

Occurs to me too in other PR: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/autoscaler/8012/pull-autoscaling-e2e-vpa-full/1977660067477983232

@adrianmoisey
Copy link
Member

/test pull-autoscaling-e2e-vpa-full

@k8s-ci-robot k8s-ci-robot merged commit 38e0fc9 into kubernetes:master Oct 13, 2025
7 checks passed
@ialidzhikov ialidzhikov deleted the enh/vpa-update-modes-docs branch October 13, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianmoisey adrianmoisey Awaiting requested review from adrianmoisey

@voelzmo voelzmo Awaiting requested review from voelzmo

1 more reviewer

@omerap12 omerap12 omerap12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adrianmoisey adrianmoisey

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ialidzhikov @k8s-ci-robot @adrianmoisey @omerap12