-
Notifications
You must be signed in to change notification settings - Fork 924
deploy datadog to gke clusters #8589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
upodroid
wants to merge
1
commit into
kubernetes:main
Choose a base branch
from
upodroid:datadog-gke-one
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Ran Plan for dir: Show OutputNote: Objects have changed outside of Terraform
Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:
# google_pubsub_subscription.kettle_subscription has been deleted
- resource "google_pubsub_subscription" "kettle_subscription" {
id = "projects/kubernetes-public/subscriptions/k8s-infra-kettle-staging"
- name = "k8s-infra-kettle-staging" -> null
# (11 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.
─────────────────────────────────────────────────────────────────────────────
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place
Terraform will perform the following actions:
# google_container_cluster.cluster will be updated in-place
~ resource "google_container_cluster" "cluster" {
id = "aaa"
name = "aaa"
# (36 unchanged attributes hidden)
~ cluster_autoscaling {
# (3 unchanged attributes hidden)
~ auto_provisioning_defaults {
# (7 unchanged attributes hidden)
- shielded_instance_config {
- enable_integrity_monitoring = false -> null
- enable_secure_boot = false -> null
}
# (2 unchanged blocks hidden)
}
# (2 unchanged blocks hidden)
}
# (30 unchanged blocks hidden)
}
# google_pubsub_subscription.kettle_subscription will be created
+ resource "google_pubsub_subscription" "kettle_subscription" {
+ ack_deadline_seconds = (known after apply)
+ effective_labels = {
+ "goog-terraform-provisioned" = "true"
}
+ filter = "attributes.eventType = \"OBJECT_FINALIZE\""
+ id = (known after apply)
+ message_retention_duration = "604800s"
+ name = "k8s-infra-kettle-staging"
+ project = "kubernetes-public"
+ terraform_labels = {
+ "goog-terraform-provisioned" = "true"
}
+ topic = "k8s-infra-kubernetes-jenkins-changes"
+ expiration_policy (known after apply)
}
# google_pubsub_subscription_iam_binding.subscription_binding will be created
+ resource "google_pubsub_subscription_iam_binding" "subscription_binding" {
+ etag = (known after apply)
+ id = (known after apply)
+ members = [
+ "serviceAccount:kettle@kubernetes-public.iam.gserviceaccount.com",
]
+ project = "kubernetes-public"
+ role = "roles/pubsub.editor"
+ subscription = "k8s-infra-kettle-staging"
}
# module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/container.admin"] will be created
+ resource "google_project_iam_binding" "project_iam_authoritative" {
+ etag = (known after apply)
+ id = (known after apply)
+ members = [
+ "serviceAccount:argocd@k8s-infra-prow.iam.gserviceaccount.com",
]
+ project = "kubernetes-public"
+ role = "roles/container.admin"
}
Plan: 3 to add, 1 to change, 0 to destroy.
Note: Objects have changed outside of Terraform
|
d4ebf07
to
d2cdc6f
Compare
Ran Plan for dir: Show OutputNote: Objects have changed outside of Terraform
Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:
# google_pubsub_subscription.kettle_subscription has been deleted
- resource "google_pubsub_subscription" "kettle_subscription" {
id = "projects/kubernetes-public/subscriptions/k8s-infra-kettle-staging"
- name = "k8s-infra-kettle-staging" -> null
# (11 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.
─────────────────────────────────────────────────────────────────────────────
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place
Terraform will perform the following actions:
# google_container_cluster.cluster will be updated in-place
~ resource "google_container_cluster" "cluster" {
id = "aaa"
name = "aaa"
# (36 unchanged attributes hidden)
~ cluster_autoscaling {
# (3 unchanged attributes hidden)
~ auto_provisioning_defaults {
# (7 unchanged attributes hidden)
- shielded_instance_config {
- enable_integrity_monitoring = false -> null
- enable_secure_boot = false -> null
}
# (2 unchanged blocks hidden)
}
# (2 unchanged blocks hidden)
}
# (30 unchanged blocks hidden)
}
# google_pubsub_subscription.kettle_subscription will be created
+ resource "google_pubsub_subscription" "kettle_subscription" {
+ ack_deadline_seconds = (known after apply)
+ effective_labels = {
+ "goog-terraform-provisioned" = "true"
}
+ filter = "attributes.eventType = \"OBJECT_FINALIZE\""
+ id = (known after apply)
+ message_retention_duration = "604800s"
+ name = "k8s-infra-kettle-staging"
+ project = "kubernetes-public"
+ terraform_labels = {
+ "goog-terraform-provisioned" = "true"
}
+ topic = "k8s-infra-kubernetes-jenkins-changes"
+ expiration_policy (known after apply)
}
# google_pubsub_subscription_iam_binding.subscription_binding will be created
+ resource "google_pubsub_subscription_iam_binding" "subscription_binding" {
+ etag = (known after apply)
+ id = (known after apply)
+ members = [
+ "serviceAccount:kettle@kubernetes-public.iam.gserviceaccount.com",
]
+ project = "kubernetes-public"
+ role = "roles/pubsub.editor"
+ subscription = "k8s-infra-kettle-staging"
}
# module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/container.admin"] will be created
+ resource "google_project_iam_binding" "project_iam_authoritative" {
+ etag = (known after apply)
+ id = (known after apply)
+ members = [
+ "serviceAccount:argocd@k8s-infra-prow.iam.gserviceaccount.com",
]
+ project = "kubernetes-public"
+ role = "roles/container.admin"
}
Plan: 3 to add, 1 to change, 0 to destroy.
Note: Objects have changed outside of Terraform
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/infra/gcp
Issues or PRs related to Kubernetes GCP infrastructure
area/infra
Infrastructure management, infrastructure design, code in infra/
area/prow
Setting up or working with prow in general, prow.k8s.io, prow build clusters
area/terraform
Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
sig/k8s-infra
Categorizes an issue or PR as relevant to SIG K8s Infra.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deployed this recently to our clusters so upgrading DD version and pushing final tweaks.