e2e_node: fix ImageGCNoEviction test for kubetest2 #130391
Open
+30
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bart0sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/test
sig/node
|
/test pull-crio-cgroupv1-node-e2e-eviction |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/priority backlog |
|
LGTM label has been added. Git tree hash: b91022a442c840dc853c6ea39de5847667be37fc
|
k8s-ci-robot
added
priority/backlog
k8s-ci-robot
removed
the
needs-triage
ImageGCNoEviction fails when tests run by kubetest2 as the test depends on the prepulled test images (framework.TestContext.PrepullImages), but kubetest2 --prepull-images command line option is set to false by default. Prepulling images explicitly for the only test that uses them should fix the issue.
bart0sh
force-pushed
the
PR174-e2e_node-fix-eviction-kubetest2
branch
from
2e2813c to
4c0b24b
Compare
k8s-ci-robot
removed
the
lgtm
|
/assign @SergeyKanzhelev @mrunalp |
|
@kannon92 Can you lgtm again? I've added image pre-pulling at the end of test. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8c67b810ae7e0e591a7dc79d575acfefae7329dc
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
/kind flake
What this PR does / why we need it:
It fixes
ImageGCNoEvictiontest, which fails when run bykubetest2. The test depends on the pre-pulled test images (framework.TestContext.PrepullImages), but kubetest2 has it disabled by default, i.e. its--prepull-imagescommand line option is set to false. As a result image GC is not able to reclaim enough inodes to get the test passing.The PR adds explicit image pre-pull for the
ImageGCNoEvictiontest, which should fix the issue.Which issue(s) this PR fixes:
Fixes: #130370
Ref: kubernetes/test-infra#32567
Does this PR introduce a user-facing change?
/sig-node