Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
  • Loading branch information
ComradeProgrammer and spowelljr committed Jan 5, 2025
1 parent b139639 commit d5f1452
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
7 changes: 4 additions & 3 deletions pkg/minikube/tunnel/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,10 @@ func (r *persistentRegistry) Register(tunnel *ID) (rerr error) {

alreadyExists := false
for i, t := range tunnels {
// it is allowed for multiple minikube clusters to have multiple tunnels simultaneously
// it is possible that an old tunnel from an old profile has duplicated route information
// so we need to check both machine name and route information
// It is allowed for multiple minikube clusters to have multiple
// tunnels simultaneously. It is possible that an old tunnel
// from an old profile has duplicated route information so we
// need to check both machine name and route information.
if tunnel.MachineName == t.MachineName && t.Route.Equal(tunnel.Route) {
isRunning, err := checkIfRunning(t.Pid)
if err != nil {
Expand Down
3 changes: 2 additions & 1 deletion site/content/en/docs/contrib/tests.en.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ asserts that there are no unexpected errors displayed in minikube command output
are functionality tests which can safely share a profile in parallel

## TestFunctionalNewestKubernetes
are functionality run functional tests using NewestKubernetesVersion
are functionality run functional tests using
NewestKubernetesVersion

#### validateNodeLabels
checks if minikube cluster is created with correct kubernetes's node label
Expand Down
3 changes: 2 additions & 1 deletion test/integration/functional_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ func TestFunctional(t *testing.T) {
testFunctional(t, "")
}

// TestFunctionalNewestKubernetes are functionality run functional tests using NewestKubernetesVersion
// TestFunctionalNewestKubernetes are functionality run functional tests using
// NewestKubernetesVersion
func TestFunctionalNewestKubernetes(t *testing.T) {
if strings.Contains(*startArgs, "--kubernetes-version") || constants.NewestKubernetesVersion == constants.DefaultKubernetesVersion {
t.Skip()
Expand Down

0 comments on commit d5f1452

Please sign in to comment.