Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Addon] add volcano addon #18798

Closed
wants to merge 2 commits into from
Closed

[Addon] add volcano addon #18798

wants to merge 2 commits into from

Conversation

lowang-bh
Copy link
Member

continue on PR #13876

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lowang-bh
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@lowang-bh
use master's deploy yaml file
cc1da4e 
Signed-off-by: lowang-bh <lhui_wang@163.com>
medyagh
medyagh reviewed May 7, 2024
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lowang-bh do you mind putting the Before After for this PR and example of using it?

medyagh
medyagh requested changes May 7, 2024
View reviewed changes
pkg/minikube/assets/addons.go
vmpath.GuestAddonsDir,
"volcano-deployment.yaml",
"0640"),
}, false, "volcano", "third-party (volcano)", "hwdef", "", map[string]string{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider adding an Auto Updater Github Action Job that automatically updates the image versions
simmilar to
https://github.com/kubernetes/minikube/blob/master/.github/workflows/update-gcp-auth-version.yml

@lowang-bh
Copy link
Member Author

@lowang-bh do you mind putting the Before After for this PR and example of using it?

I didn't get what you mean by before and after, could you please further clarify?

@medyagh
Copy link
Member

medyagh commented May 8, 2024

d after, could you please further clarify?

I mean output of running this new addon with an example of using it in terminal,

@medyagh
Copy link
Member

medyagh commented May 22, 2024

@lowang-bh thank you for this PR, I merged another PR #18602 please let me know if anything we missed from this PR and you could make a follow up PR

@medyagh medyagh closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh requested changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lowang-bh @k8s-ci-robot @minikube-bot @medyagh @hwdef