New flag to allow option for passing a config file for addon configure command.

[omleteer]

Minor UI Change (Before and After described in the ticket) but tl;dr:

BEFORE

Currently when configuring addons with the command:

minikube addons configure <addon>

eg:

minikube addons configure registry-creds

The user is prompted to input the values one by one, eg:

Do you want to enable AWS Elastic Container Registry? [y/n]:

and so on. This makes it hard to store/load values in a scripted environemnt. Some times it easier to provide a config file containing so that the values can be read from this.

AFTER

Add a "-c" local flag to the addon configure command, eg:

minikube addons configure registry-creds -c ~/.minikube/configs/registry-creds-config.json
minikube addons configure ingress -c ~/.minikube/configs/ingres-config.json

etc

[linux-foundation-easycla]

• ✅ login: dependabot[bot] (886cdf2, 1aa7e32)
• ✅ login: wuwentao / name: Hello World (8277138)
• ✅ login: ComradeProgrammer / name: 錦南路之花 (187b70f)
• ✅ login: minikube-bot (44386b1, 8e9d504, d1767ec, 9fe757e)
• ✅ login: panyam / name: Sri Panyam (1f355fa, 17e6058, 567753b, a819dbf)
• ❌ The email address for the commit (378d58e, 58d369f, f79ac35, d206935, 8ea83bc, bea313a, 73f32be, fb6364a, e672103, f275e5b, 87fa92b, da060c1) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

Welcome @omleteer!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @omleteer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omleteer
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

/check-cla

[medyagh]

/check-cla

[medyagh]

lets have top field called "addons:"

[omleteer]

+1 Done

[medyagh]

I would prefer have this in same test as other addons same cluster,
so we pass the addon config file to the same cluster that enabled bunch of addons without config file,

[omleteer]

+1. Ive have moved the test back to addons_test.

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

• 1aa7e32 Build(deps): Bump github.com/otiai10/copy from 1.14.0 to 1.14.1 (Build(deps): Bump github.com/otiai10/copy from 1.14.0 to 1.14.1 #20209)
• 886cdf2 Build(deps): Bump github.com/elazarl/goproxy (Build(deps): Bump github.com/elazarl/goproxy from 0.0.0-20210110162100-a92cc753f88e to 1.2.6 #20208)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20129) |
+----------------+----------+---------------------+
| minikube start | 74.2s    | 52.6s               |
| enable ingress | 18.7s    | 16.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 20.2s 20.7s 15.1s 19.1s 18.6s
Times for minikube (PR 20129) ingress: 19.6s 15.1s 15.6s 15.1s 18.6s

Times for minikube start: 53.5s 51.3s 51.1s 161.5s 53.6s
Times for minikube (PR 20129) start: 54.6s 51.6s 51.0s 52.5s 53.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20129) |
+----------------+----------+---------------------+
| minikube start | 25.3s    | 25.0s               |
| enable ingress | 12.7s    | 13.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.5s 26.6s 26.1s 25.1s 25.3s
Times for minikube (PR 20129) start: 24.4s 26.6s 25.6s 25.3s 22.9s

Times for minikube ingress: 12.4s 12.9s 13.4s 12.4s 12.4s
Times for minikube (PR 20129) ingress: 13.5s 13.4s 12.9s 13.4s 12.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20129) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 25.0s               |
| enable ingress | 26.2s    | 30.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.9s 22.9s 22.9s 22.7s 39.5s
Times for minikube (PR 20129) ingress: 22.9s 38.9s 22.9s 28.5s 39.5s

Times for minikube start: 24.7s 21.1s 23.8s 22.9s 23.9s
Times for minikube (PR 20129) start: 23.7s 25.4s 24.4s 26.3s 25.2s