Skip to content

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Sep 26, 2025

Commits Summary

  • change ubuntu name to debian in code base
  • update automation update tool for kicbase
  • capitalize AS in Docker instructions
  • enable RSA1 support in sshd config in debian dockerfile
  • config Docker user for Passwordless login and add to corect groups
  • install latst version of crio available in debian repos
  • update docker installation for debian based on docker docs
  • add crictl installation seprately since it is no longer shipped with crio
  • remove old workarrounds

Previous Attempts:

Todos:

Move from RSA1 to a RSA2
#21543

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nirs and prezha September 26, 2025 21:01
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2025
@medyagh
Copy link
Member Author

medyagh commented Sep 26, 2025

/ok-to-build-image

@nirs
Copy link
Contributor

nirs commented Sep 26, 2025

This must be merged together with #21409 since the preloads created with containerd 1.7 may not be correct for containerd 2.

@medyagh medyagh changed the title Switch ubuntu to debian Kicbase: Switch ubuntu jammy to debian bookworm Sep 26, 2025
@medyagh
Copy link
Member Author

medyagh commented Sep 26, 2025

This must be merged together with #21409 since the preloads created with containerd 1.7 may not be correct for containerd 2.

this doesnt touch iso, Containerd2 work can be done After this PR

@nirs
Copy link
Contributor

nirs commented Sep 26, 2025

This must be merged together with #21409 since the preloads created with containerd 1.7 may not be correct for containerd 2.

this doesnt touch iso, Containerd2 work can be done After this PR

When we update the base image we get a new version of containerd, so we ned to update also nerdctl. And since we share the preloads, we may need the same version of containerd in kicbase and iso. If this change does not bring contianerd v2 we are fine.

@medyagh
Copy link
Member Author

medyagh commented Sep 26, 2025

/ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @medyagh, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 26, 2025
@medyagh
Copy link
Member Author

medyagh commented Sep 26, 2025

/ok-to-build-image

@medyagh
Copy link
Member Author

medyagh commented Sep 26, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 26, 2025
@minikube-bot
Copy link
Collaborator

Hi @medyagh, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@medyagh
Copy link
Member Author

medyagh commented Oct 1, 2025

/ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @medyagh, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@medyagh
Copy link
Member Author

medyagh commented Oct 1, 2025

/ok-to-test

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@medyagh
Copy link
Member Author

medyagh commented Oct 2, 2025

/ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @medyagh, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot
Copy link
Contributor

@medyagh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-integration cc42fd2 link true /test pull-minikube-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21643 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 41.4s    │ 42.9s                  │
│ enable ingress │ 15.9s    │ 15.7s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 15.8s 15.8s 15.8s 15.8s 16.3s
Times for minikube (PR 21643) ingress: 15.8s 15.8s 15.8s 16.3s 14.8s

Times for minikube start: 39.8s 39.9s 41.2s 43.7s 42.2s
Times for minikube (PR 21643) start: 42.1s 46.1s 42.0s 42.2s 42.3s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21643 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.1s    │ 23.3s                  │
│ enable ingress │ 11.0s    │ 11.4s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 10.6s 10.6s 10.6s 10.6s 12.6s
Times for minikube (PR 21643) ingress: 10.6s 12.7s 10.6s 12.6s 10.6s

Times for minikube start: 22.7s 22.9s 21.5s 25.4s 23.2s
Times for minikube (PR 21643) start: 21.5s 22.2s 23.8s 24.0s 25.0s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21643 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 20.3s    │ 23.1s                  │
│ enable ingress │ 26.5s    │ 21.3s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 40.1s 23.1s 23.1s 23.1s 23.1s
Times for minikube (PR 21643) ingress: 21.1s 21.1s 21.1s 22.1s 21.1s

Times for minikube start: 18.8s 21.8s 21.5s 20.1s 19.5s
Times for minikube (PR 21643) start: 24.6s 23.3s 22.2s 23.7s 22.0s

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_containerd (9 failed) TestFunctional/parallel/DashboardCmd(gopogh) 0.00% (chart)
Docker_Linux_containerd (9 failed) TestFunctional/parallel/ServiceCmdConnect(gopogh) 0.00% (chart)
Docker_Linux_containerd (9 failed) TestFunctional/parallel/PersistentVolumeClaim(gopogh) 0.00% (chart)
Docker_Linux_containerd (9 failed) TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup(gopogh) 0.00% (chart)
Docker_Linux_containerd (9 failed) TestFunctional/parallel/ServiceCmd/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd (9 failed) TestFunctional/parallel/TunnelCmd/serial/AccessDirect(gopogh) 0.00% (chart)
Docker_Linux_containerd (9 failed) TestFunctional/parallel/ServiceCmd/HTTPS(gopogh) 0.00% (chart)
Docker_Linux_containerd (9 failed) TestFunctional/parallel/ServiceCmd/Format(gopogh) 0.00% (chart)
Docker_Linux_containerd (9 failed) TestFunctional/parallel/ServiceCmd/URL(gopogh) 0.00% (chart)
Docker_Linux_docker_arm64 (1 failed) TestScheduledStopUnix(gopogh) 8.16% (chart)
Docker_Windows (1 failed) TestErrorSpam/setup(gopogh) Unknown

Besides the following environments also have failed tests:

  • KVM_Linux_crio: 14 failed (gopogh)

  • Docker_Linux_containerd_arm64: 12 failed (gopogh)

  • Docker_Linux_crio: 56 failed (gopogh)

  • Docker_Linux_crio_arm64: 47 failed (gopogh)

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member Author

medyagh commented Oct 2, 2025

Docker Linux Passes
Docker Linux Containerd Failures are Docker hub Rate limits it passed in previous commit

Docker Linux Crio is meant to be fixed by community or droped from minikube

@medyagh medyagh merged commit 9ebf9fd into kubernetes:master Oct 2, 2025
26 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants