Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mysql:5.7 is now based on Oracle #35857

Closed
wants to merge 1 commit into from
Closed

fix: mysql:5.7 is now based on Oracle #35857

wants to merge 1 commit into from

Conversation

stefan-kolb
Copy link
Contributor

@stefan-kolb stefan-kolb commented Aug 10, 2022 •
edited
Loading

Does not include hostname binary anymore

See application/mysql/mysql-statefulset.yaml

@stefan-kolb
fix: mysql:5.7 is now based on Oracle
77a94e4 
Does not include hostname binary anymore

See application/mysql/mysql-statefulset.yaml
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign savitharaghunathan for approval by writing /assign @savitharaghunathan in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 10, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 10, 2022
sftim
sftim reviewed Aug 10, 2022
View reviewed changes
content/en/examples/application/mysql/mysql-statefulset.yaml
image: mysql:5.7
image: mysql:5.7-debian
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this the right change to make?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is based on debian again which includes the necessary hostname binary.

Copy link
Contributor Author

@stefan-kolb stefan-kolb Aug 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See docker-library/mysql#877 (sorry I wanted to add this in the commit/description as well, but did not copy the correct link).

@netlify
Copy link

netlify bot commented Aug 10, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 77a94e4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62f3ca909caa6d000810777d
😎 Deploy Preview https://deploy-preview-35857--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo jihoon-seo mentioned this pull request Aug 19, 2022
Closed
@jihoon-seo
Copy link
Member

Relevant issues:

@stefan-kolb stefan-kolb closed this by deleting the head repository Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jimangel jimangel Awaiting requested review from jimangel

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefan-kolb @k8s-ci-robot @jihoon-seo @sftim