env var for config file added #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: siddhikhapare <siddhikhapare77@gmail.com>
dwertent
reviewed
Aug 3, 2023
| @@ -26,7 +26,12 @@ import ( | |||
| func main() { | |||
| ctx := context.Background() | |||
|
|
|||
| c, err := config.LoadConfig("/etc/config") | |||
| configPath := os.Getenv("CONFIG") | |||
There was a problem hiding this comment.
@matthyx what do you think is the proper solution here? Because we are thinking of having multiple configuration files...
There was a problem hiding this comment.
Exactly, the goal is to split the config between component and cluster like in node-agent.
|
/improve |
![codiumai-pr-agent-free[bot]](https://avatars.githubusercontent.com/in/354216?s=60&v=4){kind=small}
Comment on lines
+29
to
+32
| configPath := os.Getenv("CONFIG") | ||
| if configPath == "" { | ||
| configPath = "/etc/config" | ||
| } |
There was a problem hiding this comment.
Suggestion: It's a good practice to define default values as constants at the beginning of the file or package. This makes it easier to manage and change these values in the future.
Suggested change
| configPath := os.Getenv("CONFIG") | |
| if configPath == "" { | |
| configPath = "/etc/config" | |
| } | |
| const defaultConfigPath = "/etc/config" | |
| ... | |
| configPath := os.Getenv("CONFIG") | |
| if configPath == "" { | |
| configPath = defaultConfigPath | |
| } |
Comment on lines
35
to
37
| if err != nil { | ||
| logger.L().Ctx(ctx).Fatal("load config error", helpers.Error(err)) | ||
| } |
There was a problem hiding this comment.
Suggestion: Error messages should be descriptive and provide context for easier debugging. Consider adding more information to the error message when the configuration file fails to load.
Suggested change
| if err != nil { | |
| logger.L().Ctx(ctx).Fatal("load config error", helpers.Error(err)) | |
| } | |
| if err != nil { | |
| logger.L().Ctx(ctx).Fatal("Failed to load config from path: "+configPath, helpers.Error(err)) | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use the CONFIG environment variable to load the config file, but it currently doesn't allow custom file paths. Kubevuln always defaults to searching for the config file in the /etc/config path, regardless of the CONFIG env value.
How to Test
Build kubevuln using
makeLoad config file using the CONFIG environment variable
export CONFIG=path/to/clusterData.jsonSet the PORT environment variable to 8081
export PORT=8080Related issues/PRs:
Resolved #129
Checklist before requesting a review