Fix scan image multiple creds

[amirmalka]

User description

Overview

This PR fixes an issue when working with multiple sets of image registry credentials when scanning an image:

1. append was called multiple times in a loop on RegistryOptions.Credentials, causing invalid credential objects
2. Authority should have been set to the registry name. We take the serveraddress instead of the auth field which is a base64 encoded string of "user:pass".

---

Type

Bug fix, Tests

---

Description

This PR addresses an issue with handling multiple sets of image registry credentials when scanning an image. The main changes include:

• Replacing the previous approach of appending credentials in a loop with a new function registryCredentialsFromCredentialsList that creates a list of RegistryCredentials from a list of AuthConfig.
• Adding a new function parseAuthorityFromServerAddress to extract the authority from the server address.
• Adding a new function credentialsLog to create a string representation of the credentials without the password and token for logging purposes.
• Adding tests for the new functions registryCredentialsFromCredentialsList and parseAuthorityFromServerAddress.

---

Changes walkthrough

	Relevant files
Bug fix	scan.go                                                                                                          core/services/scan.go The changes in this file mainly revolve around the handling of registry credentials. The previous approach of appending credentials in a loop was replaced with a new function registryCredentialsFromCredentialsList that creates a list of RegistryCredentials from a list of AuthConfig. This function also includes a call to parseAuthorityFromServerAddress which extracts the authority from the server address. Additionally, a new function credentialsLog was added to create a string representation of the credentials without the password and token for logging purposes. +48/-11
Tests	scan_test.go                                                                                                core/services/scan_test.go This file includes new tests for the functions registryCredentialsFromCredentialsList and parseAuthorityFromServerAddress that were added in scan.go. The tests ensure that the functions are correctly creating RegistryCredentials from AuthConfig and parsing the authority from the server address. +41/-0

---

✨ Usage guide:

---

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the describe tool is: pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...] meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: pr_commands = ["/describe --pr_description.use_description_markers=true", ...] the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following: type: the PR type. summary: the PR summary. walkthrough: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

Custom labels The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other]. If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: Main topic:performance - pr_agent:The main topic of this PR is performance New endpoint - pr_agent:A new endpoint was added in this PR SQL query - pr_agent:A new SQL query was added in this PR Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

Utilizing extra instructions The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: [pr_description] extra_instructions=""" - The PR title should be in the format: '<PR type>: <title>' - The title should be short and concise (up to 10 words) - ... """ Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

[gitguardian]

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
9273905	Generic High Entropy Secret	f14d7b5	core/services/scan_test.go	View secret
9273906	Generic High Entropy Secret	f14d7b5	core/services/scan_test.go	View secret
9273907	Generic High Entropy Secret	f14d7b5	core/services/scan_test.go	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>

[codiumai-pr-agent-free]

PR Description updated to latest commit (03f126b)

[codiumai-pr-agent-free]

PR Analysis

• 🎯 Main theme: Fixing image scanning with multiple sets of registry credentials
• 📝 PR summary: This PR addresses an issue with handling multiple sets of image registry credentials when scanning an image. The main changes include refactoring the way credentials are handled and parsed, adding new helper functions for this purpose, and adding tests for the new functions.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: Yes
• ⏱️ Estimated effort to review [1-5]: 2, because the PR is relatively small, the changes are well explained, and the code is clean and well-structured.
• 🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR is well-structured and the changes are well explained. It's good to see that tests have been added for the new functions. However, it would be better to handle errors more explicitly in the new functions, instead of silently returning default values.

🤖 Code feedback:

---

relevant file	core/services/scan.go
suggestion	Consider handling the error from url.Parse(serverAddress) more explicitly. If the URL parsing fails, it might be better to log an error or even return an error from parseAuthorityFromServerAddress, instead of silently returning the original server address. [important]
relevant line	parsedURL, err := url.Parse(serverAddress)

---

relevant file	core/services/scan.go
suggestion	In the registryCredentialsFromCredentialsList function, you are checking if cred.Username != "" && cred.Password != "" before setting the username and password. Consider handling the case where either the username or password is empty, as this might be an error situation that should be logged or handled differently. [medium]
relevant line	if cred.Username != "" && cred.Password != "" {

---

---

✨ Usage guide:

---

Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

Utilizing extra instructions The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: [pr_reviewer] # /review # extra_instructions=""" In the code feedback section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

How to enable\disable automation When you first install PR-Agent app, the default mode for the review tool is: pr_commands = ["/review", ...] meaning the review tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations

About the 'Code feedback' section The review tool provides several type of feedbacks, one of them is code suggestions. If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results. Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

Auto-labels The review tool can auto-generate two specific types of labels for a PR: a possible security issue label, that detects possible security issues (enable_review_labels_security flag) a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

Extra sub-tools The review tool provides a collection of possible feedbacks about a PR. It is recommended to review the possible options, and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: require_score_review, require_soc2_review, enable_review_labels_effort, and more.

More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success