add image manifest to scan summary #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Summary:
|
|
Summary:
|
|
Summary:
|
RinaO1234
reviewed
Jun 4, 2024
adapters/v1/backend.go
Outdated
| @@ -255,8 +255,12 @@ func (a *BackendAdapter) SubmitCVE(ctx context.Context, cve domain.CVEManifest, | |||
| vulnerabilities[i].Designators = finalReport.Designators | |||
| } | |||
|
|
|||
| imageManifest, err := parseImageManifest(sbom) | |||
| if err != nil { | |||
| return fmt.Errorf("failed to parse image manifest from sbom: %w", err) | |||
There was a problem hiding this comment.
do we want to fail the whole submit in case of this failure? do we have what to retry here at all? feels to me it's better to submit partial report
|
overall LGTM, you did a great job - just fix Rina's concern |
matthyx
approved these changes
Jun 4, 2024
|
Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview