Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/policy rules #399

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Feature/policy rules #399

wants to merge 22 commits into from

Conversation

afek854
Copy link
Contributor

@afek854 afek854 commented Nov 6, 2024

Overview

@afek854
Added rule policies
0b5d8f8 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
Added rule policy to symlink
106ccef 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
Added rule condition interface & modified rules
3c3773f 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
Added rule condition logic
0fe9fdc 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
Added rule policy reporter
bfcc7c2 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
Modified rule policy reporting process
92ab0ca 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
Modified tests & fixed enrichment
6c70b21 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
Copy link
Contributor Author

afek854 commented Nov 6, 2024

Need to update storage in go.mod before

@afek854
Added tests
db059ae 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
Merge branch 'main' of github.com:kubescape/node-agent into feature/p…
80e393e 
…olicy_rules
@afek854
Fixed create patch function
19cc5ae 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
Added support to hardlink & exec
3a3d2eb 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
Fixed symlink rule
179544e 
Signed-off-by: Afek Berger <afekb@armosec.io>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 marked this pull request as ready for review November 6, 2024 15:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 requested review from matthyx and amitschendel and removed request for matthyx November 7, 2024 07:19
@afek854 afek854 force-pushed the feature/policy_rules branch 2 times, most recently from 46cd39e to e076c4e Compare November 7, 2024 07:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854
Fixed rules test
d957650 
Signed-off-by: Afek Berger <afekb@armosec.io>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

matthyx
matthyx reviewed Nov 7, 2024
View reviewed changes
go.mod Outdated
@@ -262,3 +262,5 @@ require (
replace github.com/vishvananda/netns => github.com/inspektor-gadget/netns v0.0.5-0.20230524185006-155d84c555d6

replace github.com/goradd/maps => github.com/matthyx/maps v0.0.0-20241029072232-2f5d83d608a7

replace github.com/kubescape/storage => github.com/kubescape/storage v0.0.128-0.20241104095737-2142149b0f10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use released storage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@afek854
Added init operations
be17167 
Signed-off-by: Afek Berger <afekb@armosec.io>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854
Added Cache to savedRulePolicies
4d9a26e 
Signed-off-by: Afek Berger <afekb@armosec.io>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

1 similar comment
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854
Added component test & cache for policies
66eed95 
Signed-off-by: Afek Berger <afekb@armosec.io>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854
Fixed init ops
b14a3b2 
Signed-off-by: Afek Berger <afekb@armosec.io>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 force-pushed the feature/policy_rules branch 2 times, most recently from 3ace3da to c2f7fa4 Compare November 17, 2024 11:58
@afek854
Fixed component test
def694f 
Signed-off-by: Afek Berger <afekb@armosec.io>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 force-pushed the feature/policy_rules branch 2 times, most recently from 2bc514e to 101ebc4 Compare November 17, 2024 12:44
@afek854
Update default rule binding
afb7631 
Signed-off-by: Afek Berger <afekb@armosec.io>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthyx matthyx matthyx requested changes

@amitschendel amitschendel Awaiting requested review from amitschendel

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afek854 @matthyx